Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animate - move phone slightly #1893

Merged
merged 7 commits into from Oct 6, 2023
Merged

Animate - move phone slightly #1893

merged 7 commits into from Oct 6, 2023

Conversation

Terieyenike
Copy link
Contributor

This project uses keyframes to animate or move the phone on the screen.

@Terieyenike
Merge branch 'master' of https://github.com/zero-to-mastery/Animation…
f12a98e 
…-Nation

* 'master' of https://github.com/zero-to-mastery/Animation-Nation: (108 commits)
  docs: Change description for `include.js` (zero-to-mastery#1845)
  (CI) format code
  Solar system (zero-to-mastery#1836)
  (CI) format code
  Richard's bouncing ball with shadow (zero-to-mastery#1786)
  (CI) format code
  Add Orbiting-Ball animation (zero-to-mastery#1843)
  fix: add olga_min, fix some broken links (zero-to-mastery#1844)
  updating my card (zero-to-mastery#1833)
  (CI) format code
  Added a new card (zero-to-mastery#1842)
  Added my Animation (zero-to-mastery#1835)
  Add Aldair's art (zero-to-mastery#1834)
  (CI) format code
  Add Analog Clock Art (zero-to-mastery#1822)
  Added my art (zero-to-mastery#1809)
  The animation is a 3D cube with the letters 'LHV' on each face. (zero-to-mastery#1798)
  (CI) format code
  added loader animation (zero-to-mastery#1791)
  Fan-Samriddhi (zero-to-mastery#1790)
  ...
@Terieyenike
Feat: project boilerplate
afa59ae
@Terieyenike
Feat: add animation to the page
647b6b6
@Terieyenike
Add: gif of the project
c3d73ef
@Terieyenike
Feat: profile and project information
bb4322e
@zero-to-mastery-bot
Copy link

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

@zero-to-mastery-bot zero-to-mastery-bot bot added the Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user. label Oct 4, 2023
@zero-to-mastery-bot
Copy link

⚠️ MERGE CONFLICT DETECTED!

@Terieyenike A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

1 similar comment
@zero-to-mastery-bot
Copy link

⚠️ MERGE CONFLICT DETECTED!

@Terieyenike A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

@zero-to-mastery-bot zero-to-mastery-bot bot removed the Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user. label Oct 4, 2023
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Terieyenike, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
1893 69 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 206 2894

1 similar comment
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Terieyenike, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
1893 69 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 206 2894

MattCSmith
MattCSmith approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@MattCSmith MattCSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice job

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Terieyenike, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
1893 69 7
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 215 2942

@MattCSmith MattCSmith merged commit 3057472 into zero-to-mastery:master Oct 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattCSmith MattCSmith MattCSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Terieyenike @MattCSmith