New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set window.location properly #4

Merged
merged 2 commits into from Nov 24, 2013

Conversation

Projects
None yet
3 participants
@marbemac
Contributor

marbemac commented Nov 24, 2013

In order to play nice with iron-router, and anything else that depends on window.location, we need to update the window.location property. I tried a few methods, and updating it with the history api seems to be the best option. I have not tested this in android browsers, but it works well in iOS 5 and up.

use replaceState instead of pushState, and use the full server url.
The full server URL is needed to make DDP work.

zeroasterisk added a commit that referenced this pull request Nov 24, 2013

Merge pull request #4 from marbemac/master
set window.location properly

@zeroasterisk zeroasterisk merged commit 543c7c4 into zeroasterisk:master Nov 24, 2013

@boazhoch

This comment has been minimized.

Show comment
Hide comment
@boazhoch

boazhoch Nov 24, 2013

@marbemac @zeroasterisk tested on Android 4.3 and working

@marbemac @zeroasterisk tested on Android 4.3 and working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment