Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample target forwarding typings #248

Merged
merged 4 commits into from Nov 15, 2019

Conversation

@bloadvenro
Copy link
Contributor

bloadvenro commented Nov 15, 2019

  • test suit for sample cases using target forwarding
  • add NoInfer type hint to sample overloads using target

This will fix #247

@now

This comment has been minimized.

Copy link

now bot commented Nov 15, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/zerobias/effector/dig9mr1nn
🌍 Preview: https://effector-git-fork-bloadvenro-sample-target-forwarding-typings.zerobias.now.sh

@zerobias

This comment has been minimized.

Copy link
Owner

zerobias commented Nov 15, 2019

Cool, thanks! 👍

@zerobias zerobias merged commit 5b48555 into zerobias:master Nov 15, 2019
4 checks passed
4 checks passed
common-tests
Details
WIP Ready for review
Details
now Deployment has completed
Details
semaphoreci The build passed on Semaphore.
Details
@bloadvenro bloadvenro deleted the bloadvenro:sample-target-forwarding-typings branch Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.