Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split ssr to ssr and ssr-replacement #255

Merged
merged 2 commits into from Dec 2, 2019
Merged

Conversation

@sergeysova
Copy link
Collaborator

sergeysova commented Dec 1, 2019

effector-react/ssr contains some methods to implement forking on server
effector-react/ssr-replacement can be used to replace effector-react on server

@sergeysova sergeysova requested review from goodmind, zerobias and egorguscha Dec 1, 2019
@now

This comment has been minimized.

Copy link

now bot commented Dec 1, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/zerobias/effector/pw39kgk4s
🌍 Preview: https://effector-git-feat-split-ssr-to-replacement.zerobias.now.sh

effector-react/ssr contains some methods to implement forking on server
effector-react/ssr-replacement can be used to replace effector-react on server
@sergeysova sergeysova force-pushed the feat/split-ssr-to-replacement branch from 9a66c56 to 6c33776 Dec 1, 2019
Copy link
Owner

zerobias left a comment

All right, so be it

@zerobias zerobias merged commit e160f17 into master Dec 2, 2019
9 checks passed
9 checks passed
Test on ubuntu-latest
Details
common-tests
Details
publish-github
Details
AWS CodeBuild us-east-1 (effector-editor) Build succeeded for project effector-editor
Details
Gitpod Open an online workspace in Gitpod
Details
WIP Ready for review
Details
continuous-integration/codeship Build succeeded
Details
now Deployment has completed
Details
semaphoreci The build passed on Semaphore.
Details
@delete-merged-branch delete-merged-branch bot deleted the feat/split-ssr-to-replacement branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.