Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Do the docs need to recommend clip.reposition()? #131

Closed
smidwap opened this Issue · 6 comments

3 participants

@smidwap

The docs say that clip.reposition() needs to be called when the browser window is resized or the element is repositioned. But it looks like the repositioning is done automatically when hovering back over the "button". Should this part of the doc be removed to avoid confusion?

@JamesMGreene
Owner

It probably won't be necessary to mention once #79 is resolved... but till then, I think it's still pertinent.

@JamesMGreene

@jonrohan I'm thinking our current state now aligns with the submitter's original perception. Does that sound accurate to you? If so, I'll update the docs.

@jonrohan
Owner

yeah, it's not really needed anymore. closing this.

@jonrohan jonrohan closed this
@JamesMGreene

@jonrohan Do you mean just the note is not needed anymore, or the actual public exposure of the reposition method? I'm thinking probably both, honestly.

@jonrohan
Owner
@JamesMGreene JamesMGreene reopened this
@JamesMGreene

Reopening to update docs... PR on its way.

@JamesMGreene JamesMGreene was assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.