Remove the ability to add mouse* event handlers from API #212

Closed
JamesMGreene opened this Issue Aug 10, 2013 · 2 comments

Projects

None yet

1 participant

@JamesMGreene
ZeroClipboard member

Assuming the successful completion of #81 for Milestone 1.3, we will also deprecate the ability to add mouse* (mouseover, mouseout, mousedown, mouseup) event handlers to ZeroClipboard client instances.

When Milestone 2.0 rolls around, we could completely remove the ability to add these mouse* event handlers. However, we could also leave them intact as adding a handler via the ZC client might be a convenience for a consumer with a larger number n glued elements. I'm not terribly opinionated on this one but I feel like we should probably remove them and leave that stuff to the native DOM and/or libraries like jQuery.

Thoughts, @jonrohan? I believe this is in line with what you and I had discussed in the past.

@JamesMGreene
ZeroClipboard member

Ping @jonrohan. Here's the issue I was thinking of!

@JamesMGreene
ZeroClipboard member

To repeat my thoughts from the random side-discussion on this topic that took place in PR #352, here are my justifications for removing these mouse* event listeners from ZeroClipboard:

  • Once #81 is resolved, people can add those listeners to their elements without ZeroClipboard, e.g. with raw DOM or jQuery
  • They are the only "UI" events in ZeroClipboard; all other events are semantic
  • Having them in ZeroClipboard only adds minor potential benefit and adds what I feel is unnecessary/irrelevant bloat
@JamesMGreene JamesMGreene added a commit to JamesMGreene/zeroclipboard that referenced this issue Apr 15, 2014
@JamesMGreene JamesMGreene Dynamic Flash resizing, minimal mouse events.
Fixes #270.
Fixes #388.
Fixes #354.
Fixes #378.
Fixes #214.
Fixes #212.
Fixes #81.
Fixes #244.
7d81c04
@JamesMGreene JamesMGreene self-assigned this May 21, 2014
@JamesMGreene JamesMGreene added a commit to JamesMGreene/zeroclipboard that referenced this issue May 23, 2014
@JamesMGreene JamesMGreene MouseEvent cleanup... as best as possible.
Fixes #214.
Fixes #212.
Fixes #129.

Closes #81.

Related to #244.
Related to #369.
3916b9b
@JamesMGreene JamesMGreene added a commit to JamesMGreene/zeroclipboard that referenced this issue May 23, 2014
@JamesMGreene JamesMGreene MouseEvent cleanup... as best as possible.
Fixes #212.
Fixes #129.

Closes #214.
Closes #81.

Related to #244.
Related to #369.
2e773cc
@JamesMGreene JamesMGreene added a commit to JamesMGreene/zeroclipboard that referenced this issue May 23, 2014
@JamesMGreene JamesMGreene MouseEvent cleanup... as best as possible.
Fixes #212.
Fixes #129.

Closes #214.
Closes #81.

Related to #244.
Related to #369.
68572da
@JamesMGreene JamesMGreene closed this in #425 May 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment