Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA should not wait for response of the performer #301

Closed
t-izbassar opened this issue Feb 23, 2018 · 4 comments
Closed

QA should not wait for response of the performer #301

t-izbassar opened this issue Feb 23, 2018 · 4 comments

Comments

@t-izbassar
Copy link

@t-izbassar t-izbassar commented Feb 23, 2018

I noticed this behavior from QA: QA reviewing the task, found some rules violated. QA adds the comments with violated rules and await the confirmation of them from the task performers. See here or here.

I feel like this is just time wasting. Why QA needs task performance approval? Just mention what is violated and give the verdict. That's it. As a result, in mentioned above PR for example CR was resigned from the task as time has passed. It's already 10 day rule applicable for waiting different things to happen. Adding to that those confirmations seems redundant.

In the policy there should be mentioned how to do the verdict and there should be no waiting for some approvals from task performers.

@0crat
Copy link
Collaborator

@0crat 0crat commented Feb 23, 2018

@yegor256/z please, pay attention to this issue

@llorllale
Copy link
Contributor

@llorllale llorllale commented Feb 23, 2018

@t-izbassar I think the goal is to try to guarantee the quality of a project's documentation and not so much about reviewing the quality of job performers themselves.

@yegor256
Copy link
Member

@yegor256 yegor256 commented Mar 2, 2018

@t-izbassar the goal is to punish the performer with this extra waiting time. Next time you will think twice whether to follow the rules or not. The same happens with road police inspectors. They take a lot of time to give you a ticket, moving very slowly, in order to give you extra punishment :)

@yegor256 yegor256 closed this Mar 2, 2018
@t-izbassar
Copy link
Author

@t-izbassar t-izbassar commented Mar 2, 2018

@yegor256 nice)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.