From 633ce4ea5220c4d2a3ed70fad5e975a4bea533a2 Mon Sep 17 00:00:00 2001 From: Pylyv <70846394+Pylyv@users.noreply.github.com> Date: Sun, 25 Feb 2024 01:04:41 +0100 Subject: [PATCH] fix: Fixed Clippy warnings from issue #55 (#56) --- canyon_connection/src/lib.rs | 4 ++-- canyon_migrations/src/migrations/processor.rs | 2 +- tests/crud/querybuilder_operations.rs | 2 +- tests/migrations/mod.rs | 10 +++++----- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/canyon_connection/src/lib.rs b/canyon_connection/src/lib.rs index fd5d009e..bb313941 100644 --- a/canyon_connection/src/lib.rs +++ b/canyon_connection/src/lib.rs @@ -94,7 +94,7 @@ pub fn get_database_connection<'a>( guarded_cache .get_mut( DATASOURCES - .get(0) + .first() .expect("We didn't found any valid datasource configuration. Check your `canyon.toml` file") .name .as_str() @@ -113,7 +113,7 @@ pub fn get_database_config<'a>( ) -> &'a DatasourceConfig { if datasource_name.is_empty() { datasources_config - .get(0) + .first() .unwrap_or_else(|| panic!("Not exist datasource")) } else { datasources_config diff --git a/canyon_migrations/src/migrations/processor.rs b/canyon_migrations/src/migrations/processor.rs index ac183460..9296689f 100644 --- a/canyon_migrations/src/migrations/processor.rs +++ b/canyon_migrations/src/migrations/processor.rs @@ -701,7 +701,7 @@ impl MigrationsHelper { .collect::>(); let table_to_reference = annotation_data - .get(0) + .first() .expect("Error extracting table ref from FK annotation") .to_string(); let column_to_reference = annotation_data diff --git a/tests/crud/querybuilder_operations.rs b/tests/crud/querybuilder_operations.rs index 7fba112e..64ca46dd 100644 --- a/tests/crud/querybuilder_operations.rs +++ b/tests/crud/querybuilder_operations.rs @@ -56,7 +56,7 @@ fn test_crud_find_with_querybuilder() { let filtered_leagues: Vec = filtered_leagues_result.unwrap(); assert!(!filtered_leagues.is_empty()); - let league_idx_0 = filtered_leagues.get(0).unwrap(); + let league_idx_0 = filtered_leagues.first().unwrap(); assert_eq!(league_idx_0.id, 34); assert_eq!(league_idx_0.region, "KOREA"); } diff --git a/tests/migrations/mod.rs b/tests/migrations/mod.rs index 9ece4aac..b0fbed96 100644 --- a/tests/migrations/mod.rs +++ b/tests/migrations/mod.rs @@ -14,16 +14,16 @@ fn test_migrations_postgresql_status_query() { let res = results.unwrap(); let public_schema_info = res.get_postgres_rows(); - let first_result = public_schema_info.get(0).unwrap(); + let first_result = public_schema_info.first().unwrap(); - assert_eq!(first_result.columns().get(0).unwrap().name(), "table_name"); + assert_eq!(first_result.columns().first().unwrap().name(), "table_name"); assert_eq!( - first_result.columns().get(0).unwrap().type_().name(), + first_result.columns().first().unwrap().type_().name(), "name" ); - assert_eq!(first_result.columns().get(0).unwrap().type_().oid(), 19); + assert_eq!(first_result.columns().first().unwrap().type_().oid(), 19); assert_eq!( - first_result.columns().get(0).unwrap().type_().schema(), + first_result.columns().first().unwrap().type_().schema(), "pg_catalog" ); }