Clean GHA workflow files #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- letting golangci-lint pull latest even if the code isn't tested against that version is causing lint issues. - fixing the versions will allow us to test both before we allow support for newer go versions
Xopherus
force-pushed
the
bump-dependencies
branch
2 times, most recently
from
5ab72fc
to
8900cf1
Compare
Xopherus
commented
May 20, 2024
go.mod
Outdated
| @@ -3,6 +3,10 @@ module github.com/zerofox-oss/go-aws-msg | |||
| go 1.12 | |||
|
|
|||
| require ( | |||
| github.com/aws/aws-sdk-go v1.44.199 | |||
There was a problem hiding this comment.
Something in this update breaks tests
There was a problem hiding this comment.
v1.45 is fine
% go get -u github.com/aws/aws-sdk-go@v1.45.28
% go test ./...
? github.com/zerofox-oss/go-aws-msg [no test files]
? github.com/zerofox-oss/go-aws-msg/retryer [no test files]
ok github.com/zerofox-oss/go-aws-msg/sns 28.781s
ok github.com/zerofox-oss/go-aws-msg/sqs 16.996s
v1.46 is also fine
% go get -u github.com/aws/aws-sdk-go@v1.46.7
% go test ./...
? github.com/zerofox-oss/go-aws-msg [no test files]
? github.com/zerofox-oss/go-aws-msg/retryer [no test files]
ok github.com/zerofox-oss/go-aws-msg/sns 28.767s
ok github.com/zerofox-oss/go-aws-msg/sqs 16.984s
v1.47 is where it happens
% go get -u github.com/aws/aws-sdk-go@v1.47.13
% go test ./...
FAIL
FAIL github.com/zerofox-oss/go-aws-msg/sqs 16.749s
FAIL
Looking more into this...
There was a problem hiding this comment.
JK, so existing tests on GHA don't show the failure because they aren't running with the -race flag. When I add it, it is broken on master.
Going to repurpose this PR for cleaning up the GHA workflow files.
rynmrtn
approved these changes
May 20, 2024
shezadkhan137
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.