Fixed list/hash autofree strategy #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* zhash duplicates item value if container has autofree set * zlist duplicates item if container has autofree set This is to get around anti-pattern where caller is responsible for strdup, and forgetting it causes a double-free. It's easier to detect a dangling allocation than a double-free.
felipecruz
pushed a commit
that referenced
this pull request
Dec 8, 2012
Fixed list/hash autofree strategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was breaking systematically since it depended on caller to strdup passed values; omitting this created a hard-to-find error. Now the insert/update methods all duplicate the passed value/item for dynamic containers. If callers also duplicate the item the result is a dangling allocation, which is easy to find.