Fix windows builds #126

Merged
merged 1 commit into from Mar 26, 2013

Conversation

Projects
None yet
2 participants
Contributor

vortechs2000 commented Mar 26, 2013

The vcproj changes aren't quite as horrific as they look if you don't show the whitespace changes.

  • Only define true/false and typedef char bool on Windows when no building using
    C++ and true isn't defined. On all other platforms just use stdbool.h.
  • create a typedef for mode_t when on Windows
  • Only include platform.h on non-Windows platforms
  • Explicitly cast return type from mallocs - czmq is built with the C++ compiler
    on windows, so this is required.
  • Add zfile.c and zsys.c to the czmq vcproj definition
  • Add Ws2_32.lib and Iphlpapi.lib to the czmq_selftest.vcproj dependencies list;
    these are needed for socket-type operations.
@vortechs2000 vortechs2000 Fix windows builds
* Only define true/false and typedef char bool on Windows when no building using
  C++ and true isn't defined.  On all other platforms just use stdbool.h.
* create a typedef for mode_t when on Windows
* Only include platform.h on non-Windows platforms
* Explicitly cast return type from mallocs - czmq is built with the C++ compiler
  on windows, so this is required.
* Add zfile.c and zsys.c to the czmq vcproj definition
* Add Ws2_32.lib and Iphlpapi.lib to the czmq_selftest.vcproj dependencies list;
  these are needed for socket-type operations.
5b341b4

hintjens merged commit 8ce80e5 into zeromq:master Mar 26, 2013

Owner

hintjens commented Mar 26, 2013

Thanks for this! Can I invite you to join the maintainers' team for CZMQ?

Contributor

vortechs2000 commented Mar 27, 2013

I'd definitely be interested. Could explain to me (or point me at the
docs for) what that means? :)

On Tue, Mar 26, 2013 at 5:21 PM, Pieter Hintjens
notifications@github.comwrote:

Thanks for this! Can I invite you to join the maintainers' team for CZMQ?


Reply to this email directly or view it on GitHubhttps://github.com/zeromq/czmq/pull/126#issuecomment-15492616
.

AJ Lewis
http://thelewis.org

Owner

hintjens commented Mar 27, 2013

Our process is here: http://rfc.zeromq.org/spec:22

Contributor

vortechs2000 commented Mar 28, 2013

I would be honored to help as a maintainer.

As I read through the RFC, I realized that I haven't always been creating
issues in the issue tracker before sending the pull requests. From the Dev
Process section:

  • To initiate changes, a user SHALL log an issue on the project Platform
    issue tracker

Do we want to have issues corresponding to all pull requests, or is that
mainly for users (not contributors) to get their issues heard?

Thanks,
AJ

On Wed, Mar 27, 2013 at 6:01 PM, Pieter Hintjens
notifications@github.comwrote:

Our process is here: http://rfc.zeromq.org/spec:22


Reply to this email directly or view it on GitHubhttps://github.com/zeromq/czmq/pull/126#issuecomment-15558634
.

AJ Lewis
http://thelewis.org

Owner

hintjens commented Mar 28, 2013

I've changed that to SHOULD. In fact we rarely log issues. We should do this more, it does seem to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment