Problem: Windows only sends on one interfaces with INADDR_BROADCAST set (interface option "*") #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gle packet being sent over the interface with the highest metric.
This results in nodes not being seen on all interfaces when using the any ("*") interface, metric can be observed using the command 'route print'
Solution: SIO_GET_INTERFACE_LIST offers a cheap way of enumerating interfaces available to a specific socket so a packet can be sent per interface. Profiling shows this method at 0.006ms per invokation against 0.5ms for GetIpAddrTable meaning that this can be used on every beacon send instead of caching the results.
|
Thanks! If you have the time, would be great to get the IPv6 version working for Windows :-) |
|
I'll look into it, and thanks for cleaning up the commit. |
|
No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending to INADDR_BROADCAST on Windows only results in a single packet being sent over the interface with the highest metric.
This results in nodes not being seen on all interfaces when using the any ("*") interface, metric can be observed using the command 'route print'
Solution: SIO_GET_INTERFACE_LIST offers a cheap way of enumerating interfaces available to a specific socket so a packet can be sent per interface. Profiling shows this method at 0.006ms per invokation against 0.5ms for GetIpAddrTable meaning that this can be used on every beacon send instead of caching the results.