Rebared version of erlzmq #13

Open
wants to merge 2 commits into from

3 participants

@benoitc

rebar is more and more used in erlang world to manage erlang projects distribution and build. Here is a full rebared version of erlzmq replacing current build system.

This version also fix build on ox.

More info about rebar :

https://bitbucket.org/basho/rebar/wiki/Home

@saleyn

Is there an option not to hard code the paths in the rebar.config file?

@benoitc

no this is the only way you can do it. Exccept handling a rebar.config.template and edit path from the Makefile like I do in couch_zmq.

@saleyn

The need to modify the config file manually doesn't seem very convenient because such local changes can easily get committed to the repository, and impact people who have ZMQ installed in an alternative location. With autotools that path is given to the configure script at build-time and doesn't involve changing any sources from the repository. Perhaps generating the rebar.config from a template is a better approach, but once you do that, the question becomes - is that reinventing the wheel behind the confgiure scipt?

@saleyn

Are these replacements for UPSTREAM/DOWNSTREAM? If so, perhaps we can take out the old ones (noting the backward incompatibility)?

@benoitc

Well configure script is barely usable when you deploy an application using reltools. Also using rebar allows you to install it as a dependance of your erlang application and not pollute global space (so you can have different versions too).

Rebar config allows you to pass different path to link erlzmq against zeromq depending on your installation, that what do configure too somehow. If you want I can provide you a version of the makefile allowing you to customize CFLAGS and LDFLAGS if you need.

@saleyn

I merged your OSX and push-pull commits.

@saleyn

I'll be happy to pull your rebar changes if you can work out a solution that doesn't involve local modifications of the versioned repository files at build time.

@benoitc

I will work on it later today. Thanks anyway :)

@pusewicz

That would be great to have it merged in ;)

@saleyn

Have those changes been completed?

@benoitc

i'm not quite sure how to do it right now. I'm thinking to have a default rebar.config and eventually using autotools to build a new one. Would it be OK for your ?

@saleyn

Either that or maybe modify the bootstrap to have the user pass the vital directories that would generate rebar.config from a template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment