Couple asserts upgraded to handled errors #16

Merged
merged 3 commits into from Jun 12, 2011

Conversation

Projects
None yet
2 participants
@gar1t
Contributor

gar1t commented Jun 11, 2011

IMO those two asserts want to be handled. There are probably more, but these two jumped out at me.

yrashk added a commit that referenced this pull request Jun 12, 2011

Merge pull request #16 from gar1t/robustify
Couple asserts upgraded to handled errors

@yrashk yrashk merged commit 152e218 into zeromq:master Jun 12, 2011

@yrashk

This comment has been minimized.

Show comment
Hide comment
@yrashk

yrashk Jun 12, 2011

Member

Next time, please consider squashing your commits into one, it will make repo history nicer.

Member

yrashk commented Jun 12, 2011

Next time, please consider squashing your commits into one, it will make repo history nicer.

@gar1t

This comment has been minimized.

Show comment
Hide comment
@gar1t

gar1t Jun 12, 2011

Contributor

I generally do - I believe that second commit was post pull request. I
can -f in the future.

On Sun, Jun 12, 2011 at 7:37 AM, yrashk
reply@reply.github.com
wrote:

Next time, please consider squashing your commits into one, it will make repo history nicer.

Reply to this email directly or view it on GitHub:
#16 (comment)

Contributor

gar1t commented Jun 12, 2011

I generally do - I believe that second commit was post pull request. I
can -f in the future.

On Sun, Jun 12, 2011 at 7:37 AM, yrashk
reply@reply.github.com
wrote:

Next time, please consider squashing your commits into one, it will make repo history nicer.

Reply to this email directly or view it on GitHub:
#16 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment