This bug that this commit fixes causes getsockopt to randomly fail. The bug also makes memory overwrites possible. #30

Merged
merged 2 commits into from Feb 28, 2012

Conversation

Projects
None yet
2 participants
@epatey
Contributor

epatey commented Feb 9, 2012

Fix uninitialized variable 'option_len' in getsockopt. The parameter option_len is a pointer to an in/out variable. On input, it must specify the size of the output buffer. When uninitialized to a value smaller than the result of getsockopt, the method returns EINVAL.

epatey and others added some commits Feb 9, 2012

Fix uninitialized variable 'option_len' in getsockopt. The parameter …
…option_len is a pointer to an in/out variable. On input, it must specify the size of the output buffer. When uninitialized to a value smaller than the result of getsockopt, the method returns EINVAL.
Ransom Richardson
Fix Dialyzer warnings
Reimplement socket to not rely on undocumented list behavior
@yrashk

This comment has been minimized.

Show comment
Hide comment
@yrashk

yrashk Feb 28, 2012

Member

Sorry for the delay, I somehow missed my email notification on this. I am having somebody who's having a similar problem test your fork.

Member

yrashk commented Feb 28, 2012

Sorry for the delay, I somehow missed my email notification on this. I am having somebody who's having a similar problem test your fork.

@yrashk

This comment has been minimized.

Show comment
Hide comment
@yrashk

yrashk Feb 28, 2012

Member

It looks like it helped that person. Merging this in.

Thanks a lot!

Member

yrashk commented Feb 28, 2012

It looks like it helped that person. Merging this in.

Thanks a lot!

yrashk added a commit that referenced this pull request Feb 28, 2012

Merge pull request #30 from epatey/master
This bug that this commit fixes causes getsockopt to randomly fail. The bug also makes memory overwrites possible.

@yrashk yrashk merged commit 951aca6 into zeromq:master Feb 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment