New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileMQ uses deprecated CZMQ API's #58

Open
danriegsecker opened this Issue Nov 13, 2014 · 7 comments

Comments

Projects
None yet
2 participants
@danriegsecker
Contributor

danriegsecker commented Nov 13, 2014

There are a lot of references to deprecated czmq API's in FileMQ. Not sure if it will be acceptable, but I am working on fixing this for the c code. I do not have any expertise for Java.

@danriegsecker danriegsecker changed the title from FileMQ uses deprecated CZMQ API'ss to FileMQ uses deprecated CZMQ API's Nov 13, 2014

@hintjens

This comment has been minimized.

Show comment
Hide comment
@hintjens

hintjens Nov 14, 2014

Member

Oh, great!

If you really want to give FileMQ an overhaul, take a look at zproto for
generating the client and server. :)

-Pieter

On Thu, Nov 13, 2014 at 11:24 PM, Dan Riegsecker notifications@github.com
wrote:

There are a lot of references to deprecated czmq API's in FileMQ. Not sure
if it will be acceptable, but I am working on fixing this for the c code. I
do not have any expertise for Java.


Reply to this email directly or view it on GitHub
#58.

Member

hintjens commented Nov 14, 2014

Oh, great!

If you really want to give FileMQ an overhaul, take a look at zproto for
generating the client and server. :)

-Pieter

On Thu, Nov 13, 2014 at 11:24 PM, Dan Riegsecker notifications@github.com
wrote:

There are a lot of references to deprecated czmq API's in FileMQ. Not sure
if it will be acceptable, but I am working on fixing this for the c code. I
do not have any expertise for Java.


Reply to this email directly or view it on GitHub
#58.

@danriegsecker

This comment has been minimized.

Show comment
Hide comment
@danriegsecker

danriegsecker Nov 14, 2014

Contributor

I will look at zproto and give this my best shot. I see value in FileMQ for a project that I am working on.

Contributor

danriegsecker commented Nov 14, 2014

I will look at zproto and give this my best shot. I see value in FileMQ for a project that I am working on.

@hintjens

This comment has been minimized.

Show comment
Hide comment
@hintjens

hintjens Nov 14, 2014

Member

In fact, if you learn zproto you can rebuild FileMQ or similar stacks
fairly rapidly. FileMQ has the flaw that you can't upload a file over the
protocol, only receive them. The protocol is a good example of file
transfer, though.

On Fri, Nov 14, 2014 at 4:14 PM, Dan Riegsecker notifications@github.com
wrote:

I will look at zproto and give this my best shot. I see value in FileMQ
for a project that I am working on.


Reply to this email directly or view it on GitHub
#58 (comment).

Member

hintjens commented Nov 14, 2014

In fact, if you learn zproto you can rebuild FileMQ or similar stacks
fairly rapidly. FileMQ has the flaw that you can't upload a file over the
protocol, only receive them. The protocol is a good example of file
transfer, though.

On Fri, Nov 14, 2014 at 4:14 PM, Dan Riegsecker notifications@github.com
wrote:

I will look at zproto and give this my best shot. I see value in FileMQ
for a project that I am working on.


Reply to this email directly or view it on GitHub
#58 (comment).

@danriegsecker

This comment has been minimized.

Show comment
Hide comment
@danriegsecker

danriegsecker Dec 9, 2014

Contributor

I wasn't sure about the best way to make major updates to the existing filemq project, so I created a second project named filemq2 that can be found at https://github.com/danriegsecker/filemq2. I built this based on the RFC 35 (http://rfc.zeromq.org/spec:35) without any modifications. You will find some things that aren't yet implemented. I built this updated project using zproject and zproto. I have used this project, thus far, as a learning process for zproto and zproject. Let me know if any of this is useful to the work that was already done on the original filemq.

Contributor

danriegsecker commented Dec 9, 2014

I wasn't sure about the best way to make major updates to the existing filemq project, so I created a second project named filemq2 that can be found at https://github.com/danriegsecker/filemq2. I built this based on the RFC 35 (http://rfc.zeromq.org/spec:35) without any modifications. You will find some things that aren't yet implemented. I built this updated project using zproject and zproto. I have used this project, thus far, as a learning process for zproto and zproject. Let me know if any of this is useful to the work that was already done on the original filemq.

@hintjens

This comment has been minimized.

Show comment
Hide comment
@hintjens

hintjens Dec 9, 2014

Member

The original filemq can be scrapped, really. It was the basis for zproto.
If your code is clean and matches our style guidelines, then why not just
push it to filemq and overwrite what there is... :-)

On Tue, Dec 9, 2014 at 5:47 PM, Dan Riegsecker notifications@github.com
wrote:

I wasn't sure about the best way to make major updates to the existing
filemq project, so I created at filemq2 project that can be found at
https://github.com/danriegsecker/filemq2. I built this based on the RFC
35 (http://rfc.zeromq.org/spec:35) without any modifications. You will
find a somethings that aren't yet implemented. I built this updated project
using zproject and zproto. I have used this project, thus far, as a
learning process for zproto and zproject. Let me know if any of this is
useful to the work that was already done on the original filemq.


Reply to this email directly or view it on GitHub
#58 (comment).

Member

hintjens commented Dec 9, 2014

The original filemq can be scrapped, really. It was the basis for zproto.
If your code is clean and matches our style guidelines, then why not just
push it to filemq and overwrite what there is... :-)

On Tue, Dec 9, 2014 at 5:47 PM, Dan Riegsecker notifications@github.com
wrote:

I wasn't sure about the best way to make major updates to the existing
filemq project, so I created at filemq2 project that can be found at
https://github.com/danriegsecker/filemq2. I built this based on the RFC
35 (http://rfc.zeromq.org/spec:35) without any modifications. You will
find a somethings that aren't yet implemented. I built this updated project
using zproject and zproto. I have used this project, thus far, as a
learning process for zproto and zproject. Let me know if any of this is
useful to the work that was already done on the original filemq.


Reply to this email directly or view it on GitHub
#58 (comment).

@danriegsecker

This comment has been minimized.

Show comment
Hide comment
@danriegsecker

danriegsecker Dec 9, 2014

Contributor

Would everyone prefer to browse the code where it is or would you like me to just move it into filemq and create a pull request, where you could decide from there? I am up for whatever the community prefers. I believe I tried to follow all the community guidelines, but I know that I am not perfect. This project does currently have a lot of debug printing, which may not be appreciated.

Contributor

danriegsecker commented Dec 9, 2014

Would everyone prefer to browse the code where it is or would you like me to just move it into filemq and create a pull request, where you could decide from there? I am up for whatever the community prefers. I believe I tried to follow all the community guidelines, but I know that I am not perfect. This project does currently have a lot of debug printing, which may not be appreciated.

@hintjens

This comment has been minimized.

Show comment
Hide comment
@hintjens

hintjens Dec 9, 2014

Member

As a general rule it's better to merge first and improve later.
On Dec 9, 2014 6:04 PM, "Dan Riegsecker" notifications@github.com wrote:

Would everyone prefer to browse the code where it is or would you like me
to just move it into filemq and create a pull request, where you could
decide from there? I am up for whatever the community prefers. I believe I
tried to follow all the community guidelines, but I know that I am not
perfect. This project does currently have a lot of debug printing, which
may not be appreciated.


Reply to this email directly or view it on GitHub
#58 (comment).

Member

hintjens commented Dec 9, 2014

As a general rule it's better to merge first and improve later.
On Dec 9, 2014 6:04 PM, "Dan Riegsecker" notifications@github.com wrote:

Would everyone prefer to browse the code where it is or would you like me
to just move it into filemq and create a pull request, where you could
decide from there? I am up for whatever the community prefers. I believe I
tried to follow all the community guidelines, but I know that I am not
perfect. This project does currently have a lot of debug printing, which
may not be appreciated.


Reply to this email directly or view it on GitHub
#58 (comment).

danriegsecker added a commit to danriegsecker/filemq that referenced this issue Dec 10, 2014

Issue #58: FileMQ uses deprecated CZMQ API's
Problem: FileMQ is way out of date and is using a lot of deprecated
CZMQ API's. The original FileMQ was also the basis for the zproto
and zproject projects.

Solution: Recreate FileMQ based on the zproto and zproject.

hintjens added a commit that referenced this issue Dec 10, 2014

Merge pull request #59 from danriegsecker/master
Issue #58: FileMQ uses deprecated CZMQ API's
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment