fix code to run under win32 #4

Merged
merged 1 commit into from Dec 11, 2012

Projects

None yet

2 participants

@pijyoi
Contributor
pijyoi commented Dec 11, 2012

issues:
fmq_hash_update() asserts non-alignment failure on win32/x86 as sizeof(fmq_chunk_t) is 12 bytes.

other than that, fmq_selftest runs without assertions.

@hintjens hintjens merged commit d8417bb into zeromq:master Dec 11, 2012
Owner

Thanks for the fix! If you have an MSVC project, you could add that to the code too.

Contributor
pijyoi commented Dec 12, 2012

Actually I am using Mingw32 which does support some C99, so the code may
still not compile cleanly under MSVC.
I also used public domain sha1.c rather than attempt to compile openssl
library.

On Wed, Dec 12, 2012 at 12:08 AM, Pieter Hintjens
notifications@github.comwrote:

Thanks for the fix! If you have an MSVC project, you could add that to the
code too.


Reply to this email directly or view it on GitHubhttps://github.com/zeromq/filemq/pull/4#issuecomment-11249578.

Owner

OK, sounds good.

On Wed, Dec 12, 2012 at 8:47 AM, pijyoi notifications@github.com wrote:

Actually I am using Mingw32 which does support some C99, so the code may
still not compile cleanly under MSVC.
I also used public domain sha1.c rather than attempt to compile openssl
library.

On Wed, Dec 12, 2012 at 12:08 AM, Pieter Hintjens
notifications@github.comwrote:

Thanks for the fix! If you have an MSVC project, you could add that to
the
code too.


Reply to this email directly or view it on GitHub<
https://github.com/zeromq/filemq/pull/4#issuecomment-11249578>.


Reply to this email directly or view it on GitHubhttps://github.com/zeromq/filemq/pull/4#issuecomment-11279708.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment