Skip to content
Commits on Feb 13, 2016
  1. @c-rack

    Merge pull request #1803 from bluca/ci_default_only_on_secondary

    c-rack committed
    Problem: too many CI builds
Commits on Feb 12, 2016
  1. @bluca

    Problem: too many CI builds

    bluca committed
    Solution: remove libsodium and no curve builds from cmake and android
  2. @bluca

    Merge pull request #1802 from hintjens/master

    bluca committed
    Problem: tests don't build on Windows
  3. @hintjens

    Problem: tests don't build on Windows

    hintjens committed
    There were numerous small issues with test cases:
    
    - some lacked the right source file header
    - some were not portable at all
    - some were using internal libzmq APIs (headers)
    
    Solution: fixed and cleaned up.
  4. @bluca

    Merge pull request #1800 from hintjens/master

    bluca committed
    Cleaning up Windows build for gyp
  5. @hintjens

    Problem: tests don't build on Windows

    hintjens committed
    There were numerous small issues with test cases:
    
    - some lacked the right source file header
    - some were not portable at all
    - some were using internal libzmq APIs (headers)
    
    Solution: fixed and cleaned up.
  6. @hintjens

    Problem: people don't know how to write test cases

    hintjens committed
    Solution: document the minimum rules in README.md
  7. @hintjens

    Problem: no clue how to run gyp on Windows

    hintjens committed
    Solution: offer a build.bat to help the user.
  8. @bluca

    Merge pull request #1799 from hintjens/master

    bluca committed
    Making gyp builds work
  9. @hintjens

    Problem: gyp does not build tests

    hintjens committed
    Solution: it's a lot of work to define the tests in project.gyp
    so I did this using gsl to generate the JSON, from a small XML
    list of the test cases.
    
    To keep this, and the hundreds of .mk files, away from the root
    directory, I've moved the gyp files into builds/gyp, where you
    would run them.
    
    It all seems to work now. Next up, OS/X and Windows :)
  10. @hintjens

    Problem: minor glitch, test_socketopt_hwm <> test_sockopt_hwm

    hintjens committed
    Doesn't affect building, just potentially confusing.
    
    Solution: fix it.
  11. @hintjens

    Problem: tcp_address.cpp has messy include usage

    hintjens committed
    It's all over the place.
    
    Solution: remove duplicates and try to move main includes to start
    of source. Also, include net/if.h always, so that the code will
    compile if ZMQ_HAVE_IFADDRS isn't defined.
  12. @hintjens

    Problem: tcp_address.cpp won't compile on OS/X w/o ZMQ_HAVE_IFADDRS

    hintjens committed
    This is rather insane since the code knows well enough what systems
    support if_nametoindex. I blame this on over-use of autotools early
    in libzmq's days.
    
    Anyhow, this breaks gyp builds on OS/X.
    
    Solution: add ZMQ_HAVE_IFADDRS to build/gyp/platform.hpp for OS/X.
  13. @c-rack

    Merge pull request #1798 from hintjens/master

    c-rack committed
    Getting gyp build working
  14. @hintjens

    Problem: can't build libzmq.a using gyp

    hintjens committed
    Solution: add necessary macros into builds/gyp/platform.hpp
    
    Work for Linux now, other platforms to test.
Commits on Feb 11, 2016
  1. @jemc

    Merge pull request #1797 from bluca/ci_matrix

    jemc committed
    Problem: CI use of sodium or nacl is confusing
  2. @bluca

    Problem: CI use of sodium or nacl is confusing

    bluca committed
    Solution: establish a matrix of CI options. On one axis we have the
    build system (autotools, cmake, android) and on the other axis we
    have the encryption options (tweetnacl, libsodium or none).
  3. @hintjens

    Merge pull request #1796 from bluca/cmake_build

    hintjens committed
    Problem: typo in CMake platform.hpp breaks build
  4. @bluca

    Problem: typo in CMake platform.hpp breaks build

    bluca committed
    Solution: use ZMQ_USE_TWEETNACL as a define as expected instead of
    HAVE_TWEETNACL
  5. @hintjens

    Problem: can't build using gyp

    hintjens committed
    I'm adding gyp support so that we can easily pull in libzmq
    and other C/C++ projects into gyp packages, especially via
    node-gyp.
    
    Solution: add gyp definition
    
    This works only for Windows, OS/X, and Linux. We set a single
    macro in project.gyp according to the system, and the rest is
    done in builds/gyp/platform.hpp. The values in that file are
    not dynamic. Your mileage will vary.
  6. @hintjens

    Merge pull request #1795 from bluca/ci_tweetnacl

    hintjens committed
    Problem: CI is borken
  7. @bluca

    Problem: empty files are against ISO C++

    bluca committed
    Solution: if not building with tweetnacl, do not include its sources
    in Makefile.am. CMake already includes them optionally.
  8. @bluca

    Problem: typo in CMakeLists "matches" keyword

    bluca committed
    Solution: must be upper case
  9. @bluca

    Problem: typo in CMakeLists.txt, can't use sodium

    bluca committed
    Solution: check for WITH_LIBSODIUM configure option instead of
    WITH_SODIUM
  10. @bluca

    Problem: typo in configure.ac, can't use libsodium

    bluca committed
    Solution: set the curve_library variable to the expected value if
    libsodium is selected
  11. @bluca

    Problem: CMake CI build still clones libsodium

    bluca committed
    Solution: avoid cloning libsodium, default build is tweetnacl
  12. @bluca

    Problem: Android CI build uses unstable libsodium

    bluca committed
    Solution: checkout stable branch before building
  13. @bluca

    Problem: CI still thinks libsodium is default

    bluca committed
    Solution: build by default with tweetnacl, and add sub-build project
    to test libsodium
  14. @bluca

    Merge pull request #1794 from hintjens/master

    bluca committed
    Problem: tweetnacl sources are a mess
  15. @hintjens

    Problem: tweetnacl sources are a mess

    hintjens committed
    - they have no copyright / license statement
    - they are in some randomish directory structure
    - they are a mix of postable and non-portable files
    - they do not conform to conditional compile environment
    
    Overall, it makes it rather more work than needed, in build scripts.
    
    Solution: clean up tweetnacl sauce.
    
    - merged code into single tweetnacl.c and .h
    - standard copyright header, DJB to AUTHORS
    - moved into src/ along with all other source files
    - all system and conditional compilation hidden in these files
    - thus, they can be compiled and packaged in all cases
    - ZMQ_USE_TWEETNACL is set when we're using built-in tweetnacl
    - HAVE_LIBSODIUM is set when we're using external libsodium
  16. @c-rack
  17. @hintjens

    Problem: some configure options are confusing

    hintjens committed
    It's especially annoying to see this:
    
      --enable-perf           Build performance measurement tools [default=yes].
      --disable-eventfd       disable eventfd [default=no]
      --enable-curve-keygen   Build curve key-generation tool [default=yes].
    
    Solution: all options should explain the non-default case. Also
    the language should be enable/disable, with/without, rather than
    yes/no. E.g. '--without-docs'.
  18. @hintjens

    Merge pull request #1792 from bluca/fix_gitignore

    hintjens committed
    Problem: old filenames in .gitignore
  19. @bluca

    Merge pull request #1791 from hintjens/master

    bluca committed
    Problem: autotools platform.hpp is not compatible with CMake
  20. @bluca

    Problem: old filenames in .gitignore

    bluca committed
    Solution: remove them
Something went wrong with that request. Please try again.