Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem: zeromq connects peer before handshake is complete #3913

Merged
merged 2 commits into from May 14, 2020

Conversation

somdoron
Copy link
Member

Solution: delay connecting the peer pipe until the handshake is complete

Solution: delay connecting the peer pipe until the handshake is completed
@somdoron somdoron requested a review from bluca May 13, 2020 20:04
The test assumed the subscriptions are arrived in some order, but occasionally the order is not as expected

Solution: fix it
@somdoron
Copy link
Member Author

@bluca PR is ready

@bluca bluca merged commit afacdbe into zeromq:master May 14, 2020
@bluca
Copy link
Member

bluca commented May 14, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants