MSVC fixes #538

Merged
merged 3 commits into from Apr 1, 2013

Projects

None yet

3 participants

@TTimo
Contributor
TTimo commented Mar 31, 2013

I think 2010 can still read those projects after the conversion to 2012. If not I can fork out a different set of project files.

@hintjens hintjens merged commit b5ace90 into zeromq:master Apr 1, 2013
@steve-o
Contributor
steve-o commented on 574fe35 Apr 1, 2013

This overwrote the MSVC2010 solution file with MSVC2012?

Executables for Win32 should be v110_xp if going this route.

Contributor
TTimo replied Apr 1, 2013

That's the part I'm not sure about. It looked like both 2010 and 2012 would be able to read those project files. Do you have 2010? Does it complain about those new project files? Should be able to obtain a set for 2010 by just removing the v110 blocks (which I don't mind doing if necessary, but I'd rather someone with access to 2010 look at it)

Contributor
Contributor
Contributor
TTimo replied Apr 1, 2013
Contributor
TTimo replied Apr 7, 2013
Contributor
Contributor

There is a prebuild event in the MSVC 2012 project that copies platform.hpp to the right spot:
copy ..\platform.hpp ......\src

Maybe you can add it to MSVC 2010 solution and submit a patch?

Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
@steve-o
Contributor
steve-o commented on 5973b4c Apr 1, 2013

Why not just revert commit a22714d? I see no value reproducing the zmq::clock_t code here.

Contributor
TTimo replied Apr 1, 2013

I have no opinion about removing code that landed more than a month ago. I assume that if it's still there, it has some useful purpose. It seemed appropriate to do some simple fixes so it would compile on Windows. I am not sure what those two tools do.

Contributor

I'm waiting on that commit for feedback on what constitutes "better timing".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment