New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBSCRIBE/UNSUBSCRIBE notifies state changing for gevent #951

Merged
merged 4 commits into from Dec 14, 2016

Conversation

Projects
None yet
2 participants
@sublee
Contributor

sublee commented Dec 13, 2016

set() with SUBSCRIBE and UNSUBSCRIBE actually sends a message like send(). So this event should be notified to the I/O loop.

This patch fixes one of crash issues on PUB/SUB sockets.

@minrk minrk merged commit 9206c68 into zeromq:master Dec 14, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@minrk

This comment has been minimized.

Member

minrk commented Dec 14, 2016

Thanks!

sublee added a commit to what-studio/pyzmq that referenced this pull request Feb 12, 2018

sublee added a commit to what-studio/pyzmq that referenced this pull request Feb 12, 2018

@sublee sublee referenced this pull request Feb 13, 2018

Closed

Test PUB/SUB crash #1141

sublee added a commit to what-studio/pyzmq that referenced this pull request Feb 13, 2018

sublee added a commit to what-studio/pyzmq that referenced this pull request Feb 14, 2018

sublee added a commit to what-studio/pyzmq that referenced this pull request Feb 14, 2018

@sublee sublee referenced this pull request Feb 14, 2018

Merged

Revert PR #951 #1142

minrk added a commit that referenced this pull request Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment