Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BUILD.md in root dir #370

Merged
merged 1 commit into from Dec 13, 2015
Merged

Add BUILD.md in root dir #370

merged 1 commit into from Dec 13, 2015

Conversation

@keent
Copy link
Member

@keent keent commented Dec 13, 2015

No description provided.

keent added a commit that referenced this pull request Dec 13, 2015
Problem: No build instructions.
Solution: Add BUILD.md in root dir
@keent keent merged commit 918216a into zeromq:master Dec 13, 2015
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@c-rack
Copy link
Member

@c-rack c-rack commented Dec 13, 2015

Please do not merge your own pull requests. According to http://rfc.zeromq.org/spec:22,

Maintainers SHOULD NOT merge their own patches except in exceptional cases, such as non-responsiveness from other Maintainers for an extended period (more than 1-2 days).

Additionally, I guess it should be ./configure instead of ./configure.sh.

keent added a commit to keent/zyre that referenced this pull request Dec 13, 2015
@keent
Copy link
Member Author

@keent keent commented Dec 13, 2015

@c-rack I might have accidentally clicked merged. Sorry for that. Here's the update.

c-rack added a commit that referenced this pull request Dec 13, 2015
Update pull request #370
@c-rack
Copy link
Member

@c-rack c-rack commented Dec 13, 2015

Never mind, thanks for #371!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.