New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem: zproject out of date #570

Merged
merged 5 commits into from Feb 12, 2018

Conversation

Projects
None yet
2 participants
@wesyoung
Contributor

wesyoung commented Feb 11, 2018

solution: regen zproject

@bluca

This comment has been minimized.

Member

bluca commented Feb 11, 2018

There's a change missing? See CI failure

@wesyoung

This comment has been minimized.

Contributor

wesyoung commented Feb 12, 2018

ha- there's a real @me ... sorry meant @wesyoung :)

@bluca

This comment has been minimized.

Member

bluca commented Feb 12, 2018

Still shows a diff - make sure to have libzmq checked out in the same parent directory as zyre and czmq, with that exact name "libzmq"

@wesyoung

This comment has been minimized.

Contributor

wesyoung commented Feb 12, 2018

i just realized that- i think i've run into this problem before based on the way i setup my vagrant bits. you'd think i would have updated them last time around- NOPE>>>

@wesyoung

This comment has been minimized.

Contributor

wesyoung commented Feb 12, 2018

i think the other part of the problem is- when i first PR'd this:

https://github.com/zeromq/zproject/blob/master/zproject_vagrant.gsl#L31

i didn't embed those checkouts to the local dir, which is what i use as a template (so i don't have to remember things). need to clean that up too i guess.

wesyoung added some commits Feb 12, 2018

@bluca bluca merged commit def11a8 into zeromq:master Feb 12, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@bluca

This comment has been minimized.

Member

bluca commented Feb 12, 2018

Thanks!

@wesyoung wesyoung deleted the wesyoung:fix/zproject branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment