Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems: zbeacon does not work anymore, unclear API name and documentation #594

Merged
merged 4 commits into from Aug 3, 2018

Conversation

Projects
None yet
3 participants
@bluca
Copy link
Member

bluca commented Aug 3, 2018

Solutions: fix the zbeacon breackage from #593 and change the new API to be more specific

bluca added some commits Aug 3, 2018

Problem: zbeacon with random listening port is broken
Solution: don't use 0 to indicate random system port, czmq is not
the BSD socket API. Store the port as a string, and use * as before
for the default random port case.
Problem: ephemeral port documentation is not clear
Solution: clarify what the port will be used for
Problem: there are many ephemeral ports used by Zyre
Solution: rename the ephemeral_port API call to beacon_peer_port to
disambiguate and made it immediately clear to users that it only
affects beacon mode.
Problem: out of date with zproject
Solution: regenerate
@bluca

This comment has been minimized.

Copy link
Member Author

bluca commented Aug 3, 2018

@keent keent merged commit 255d72d into zeromq:master Aug 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bluca bluca deleted the bluca:bork branch Aug 3, 2018

@stephan57160

This comment has been minimized.

Copy link
Contributor

stephan57160 commented Aug 4, 2018

@bluca:
Thx for information, and sorry for that.

stephan57160 added a commit to stephan57160/zyre that referenced this pull request Aug 8, 2018

Problem: zeromq#594 missed README.md, when renamed zyre_set_ephemeral…
…_port().

Solution: Update README.md, accordingly (issue zeromq#595).

sphaero added a commit that referenced this pull request Aug 8, 2018

Merge pull request #596 from stephan57160/master
Problem: #594 missed README.md, when renamed zyre_set_ephemeral_port().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.