New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem: zyre missing GOSSIP UNPUBLISH command #607

Merged
merged 2 commits into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@wesyoung
Contributor

wesyoung commented Oct 4, 2018

solution: add it since ZYRE already takes care of node staleness (pings/pongs/evasive/EXIT)

in your application code when you see an EXIT (and you're using gossip) you just trigger an UNPUBLISH of the node (uuid) to remove the node from your local gossip cache IF you want to. that way when new nodes join, you're not re-broadcasting dead nodes to new connections.

a high level example of this in wesyoung/pyzyre is forthcoming for testing. hopefully one day this will be more baked into zgossip itself, wanted to start at the higher level and test (over the wide open internet) then push some of those ideas down into czmq as they mature.

reference (and merge PRE-REQ): zeromq/czmq#1943

wesyoung added some commits Oct 4, 2018

@wesyoung wesyoung changed the title from Fix/gossip unpublish to problem: zyre missing GOSSIP UNPUBLISH command Oct 4, 2018

@bluca bluca merged commit 067c9ec into zeromq:master Oct 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wesyoung wesyoung deleted the wesyoung:fix/gossip-unpublish branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment