Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem : the evasive event is not meaningful enough to detect possibly dead peers #645

Merged
merged 3 commits into from Oct 6, 2019

Conversation

@stvales
Copy link

stvales commented Oct 6, 2019

Solution : introduce a new SILENT event triggered one second after EVASIVE currently is if ping has not been answered.

NB: the EVASIVE event could safely be deprecated with this modification and that would avoid triggering an event that does not make sense if peer is just quiet for some time (which makes sense in many cases).

ingenuityio added 3 commits Sep 7, 2019
…e every 5 seconds"

This reverts commit 58ad1ae.
NB: evasive could be safely deprecated with this modification
@sappo sappo merged commit 096e658 into zeromq:master Oct 6, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.