Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows fixes, CI and build instructions #662

Merged
merged 13 commits into from Mar 10, 2020
Merged

Windows fixes, CI and build instructions #662

merged 13 commits into from Mar 10, 2020

Conversation

@sappo
Copy link
Member

sappo commented Mar 10, 2020

No description provided.

sappo added 12 commits Mar 8, 2020
Solution: Add appveyor builds
Solution: Remove the invalid '&&'s
Solution: Call zsys_shutdown explicitly because it doesn't work
automatically on windows.
Solution: Migrate tcp endpoints to inproc endpoints
Solution: Check wheater NDEBUG is defined and still include the assert.h
header in that case.
Solution: Add them based on the appveyor build script
Solution: Compile and install czmq-jni beforehand
Solution: Try to set contest before joining group. Also drop sleep
action as it is not necessary
Solution: Copy them from install prefix to hit two birds with one stone.
Also include the remaining binaries.
Solution: Skip them for now
@sappo sappo force-pushed the sappo:master branch from 846a2a1 to e359873 Mar 10, 2020
@@ -63,6 +63,14 @@
# endif
#endif

#ifdef NDEBUG

This comment has been minimized.

Copy link
@bluca

bluca Mar 10, 2020

Member

This shouldn't be in the public header - it will have an unpredictable effect on downstream applications, possibly breaking them. Could you move it to an internal header?

This comment has been minimized.

Copy link
@sappo

sappo Mar 10, 2020

Author Member

Good point. Do you think its worth having this for each zproject based project in their private headers. After all our recommendation is not to disable asserts for release builds. Why not enforce it.

This comment has been minimized.

Copy link
@bluca

bluca Mar 10, 2020

Member

Yes, that makes sense to me

Solution: Re-generate!
@sappo sappo force-pushed the sappo:master branch from cb8a760 to 2e1b245 Mar 10, 2020
@keent keent merged commit ef644e0 into zeromq:master Mar 10, 2020
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.