Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message d'avertissement pas en UTF8 = 500 #1631

Closed
Eskimon opened this issue Oct 27, 2014 · 5 comments

Comments

@Eskimon
Copy link
Member

commented Oct 27, 2014

Ce message d'erreur n'est pas en utf8 et donc entraîne un message d'erreur:

https://github.com/zestedesavoir/zds-site/blob/dev/zds/gallery/views.py#L112

(question subsidiaire, comment a t'il passe la QA ?)

Pour resoudre si vous avez 5 minutes : Rajouter un "u" devant la declaration de la chaine pour la passer en unicode.
Bonus : rajouter un TU...

@Eskimon Eskimon added this to the "Futur proche" (v1.x) milestone Oct 27, 2014

@Situphen

This comment has been minimized.

Copy link
Contributor

commented Oct 27, 2014

Je m'occupe de ça en même temps que l'issue #1633. Par contre pour les TU, je n'en ai jamais fait mais je veux bien essayer.

@Eskimon

This comment has been minimized.

Copy link
Member Author

commented Oct 27, 2014

Pour les tests, regarde ce qui se fait dans zds/members/tests/ :) et n’hésite pas a demander :)

@gustavi

This comment has been minimized.

Copy link
Member

commented Oct 28, 2014

Plus d'infos sur le bug (j'avais ouvert une autre issue sans faire exprès).

Reproduire le bug :

  • Créer un tutoriel avec un caractère accentué (« é » par exemple)
  • Essayer de supprimer la galerie associé

Les logs en détail :

zds.gallery.views in modify_gallery
UnicodeEncodeError: 'ascii' codec can't encode characters in position 5-7: ordinal not in range(128)

Stacktrace (most recent call last):
  File "django/core/handlers/base.py", line 112, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "zds/member/decorator.py", line 19, in _can_write_and_read_now
    return func(request, *args, **kwargs)
  File "django/views/decorators/http.py", line 41, in inner
    return func(request, *args, **kwargs)
  File "django/contrib/auth/decorators.py", line 22, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "zds/gallery/views.py", line 112, in modify_gallery
    gallery.title))
@gustavi

This comment has been minimized.

Copy link
Member

commented Oct 28, 2014

Est-ce qu'il est possible de rendre les titres des issues qui concernent des 500 un peu plus explicites ?

@SpaceFox SpaceFox modified the milestones: Version 1.3, "Futur proche" (v1.x) Nov 12, 2014

@SpaceFox

This comment has been minimized.

Copy link
Member

commented Nov 12, 2014

Mergé.

@SpaceFox SpaceFox closed this Nov 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.