Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renommage de get_alerts_posts_count en get_active_alerts_count #4089

Merged
merged 1 commit into from Jan 3, 2017

Conversation

@gcodeur
Copy link
Member

commented Dec 20, 2016

Q R
Type de modification évolution

Cette pull request améliore le nom de la méthode renvoyant le nombre d'alertes actives. get_alerts_posts_count est renommé en get_active_alerts_count.

QA

  • Vérifier que le nombre d'alertes est correct ;
  • Vérifier que le test zds.member.tests.tests_models.MemberModelsTest.test_get_active_alerts_count passe toujours.
@coveralls

This comment has been minimized.

Copy link

commented Dec 20, 2016

Coverage Status

Coverage remained the same at 87.09% when pulling 149f322 on GCodeur:nom_methode_nombre_alertes into eba69f7 on zestedesavoir:dev.

@artragis

This comment has been minimized.

Copy link
Member

commented Jan 3, 2017

à merger . La logique n'est pas modifiée et le test passe.

Donc c'est ok pour moi.

@pierre-24

This comment has been minimized.

Copy link
Member

commented Jan 3, 2017

ça va :)

@pierre-24 pierre-24 merged commit 6d0ecc2 into zestedesavoir:dev Jan 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pierre-24 pierre-24 removed the QA svp label Jan 3, 2017

@pierre-24 pierre-24 added this to the Version de développement milestone Jan 3, 2017

@gcodeur gcodeur referenced this pull request Feb 14, 2017
17 of 25 tasks complete

@gcodeur gcodeur deleted the gcodeur:nom_methode_nombre_alertes branch Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.