New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Empêche l'auto-ping #4203

Closed
wants to merge 2 commits into
base: dev
from

Conversation

Projects
None yet
4 participants
@vhf
Member

vhf commented Feb 12, 2017

Q R
Type de modification correction de bug
Ticket(s) (issue(s)) concerné(s) #4198

TODO

  • tests

QA

  • Activer le ping
  • Se pinger dans un commentaire, post, n'importe où en fait, en créant un commentaire ou en éditant un commentaire dont vous êtes l'auteur
  • Vérifier que vous ne recevez pas de notification

@vhf vhf added C-Back S-BUG labels Feb 12, 2017

@vhf vhf added this to the Version de développement milestone Feb 12, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 12, 2017

Coverage Status

Coverage decreased (-0.004%) to 89.607% when pulling 8ce3b05 on vhf:no-autoping into 1e03043 on zestedesavoir:dev.

coveralls commented Feb 12, 2017

Coverage Status

Coverage decreased (-0.004%) to 89.607% when pulling 8ce3b05 on vhf:no-autoping into 1e03043 on zestedesavoir:dev.

for username in list(md_instance.metadata.get('ping', []))[:settings.ZDS_APP['comment']['max_pings']]:
usernames_to_ping = list(md_instance.metadata.get('ping', []))
if self.author.username in usernames_to_ping:

This comment has been minimized.

@sandhose

sandhose Feb 12, 2017

Member

Pourquoi pas faire le filter direct ? De toutes façons tu fais un parcours de la liste une première fois avec ça

@sandhose

sandhose Feb 12, 2017

Member

Pourquoi pas faire le filter direct ? De toutes façons tu fais un parcours de la liste une première fois avec ça

This comment has been minimized.

@vhf

vhf Feb 12, 2017

Member

Tout à fait.

@vhf

vhf Feb 12, 2017

Member

Tout à fait.

@artragis artragis referenced this pull request Apr 10, 2017

Closed

Dernier appel pour la v23 #4278

3 of 3 tasks complete

@artragis artragis removed this from the Version de développement milestone Apr 11, 2017

@vhf vhf changed the title from Empêche l'auto-ping to [WIP] Empêche l'auto-ping Aug 4, 2017

@vhf vhf closed this Mar 22, 2018

@vhf vhf deleted the vhf:no-autoping branch Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment