New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajoute d'un compteur de commentaires pour les billets #4328

Merged
merged 1 commit into from May 2, 2017

Conversation

Projects
None yet
4 participants
@rezemika
Contributor

rezemika commented May 2, 2017

Q R
Type de modification évolution
Ticket(s) (issue(s)) concerné(s) #4325

Il s'agit de mon premier usage de git et de ma première PR, donc n'hésitez pas à me le dire si je ne suis pas les conventions (pour la QA par ex.). Merci ! :)

QA

  • Vérifier que le compteur de commentaires est présent sur la page d'accueil et la liste des billets.
  • Ça fonctionne !
  • Code relu et approuvé !
@artragis

This comment has been minimized.

Show comment
Hide comment
@artragis

artragis May 2, 2017

Contributor

\o/ on a un nouveau ! Bien joué pour la PR. J'ajoute ça dans le projet v24 :)

Contributor

artragis commented May 2, 2017

\o/ on a un nouveau ! Bien joué pour la PR. J'ajoute ça dans le projet v24 :)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 2, 2017

Coverage Status

Coverage remained the same at 88.636% when pulling 38a720c on rezemika:zds-rezemika into 958d824 on zestedesavoir:dev.

coveralls commented May 2, 2017

Coverage Status

Coverage remained the same at 88.636% when pulling 38a720c on rezemika:zds-rezemika into 958d824 on zestedesavoir:dev.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 2, 2017

Coverage Status

Coverage decreased (-33.0%) to 55.637% when pulling 38a720c on rezemika:zds-rezemika into 958d824 on zestedesavoir:dev.

coveralls commented May 2, 2017

Coverage Status

Coverage decreased (-33.0%) to 55.637% when pulling 38a720c on rezemika:zds-rezemika into 958d824 on zestedesavoir:dev.

@gcodeur gcodeur self-requested a review May 2, 2017

@gcodeur

gcodeur approved these changes May 2, 2017

Tout OK pour moi, félicitations pour cette première PR ! \o/

@gcodeur gcodeur added this to the Version de développement milestone May 2, 2017

@gcodeur gcodeur merged commit 9317fcb into zestedesavoir:dev May 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment