New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rend optionnel le champ 'Se souvenir de moi' dans le formulaire de connexion #4493

Merged
merged 5 commits into from Aug 7, 2017

Conversation

Projects
None yet
4 participants
@rezemika
Contributor

rezemika commented Aug 7, 2017

Q R
Type de modification correction de bug
Ticket(s) (issue(s)) concerné(s) #4492

QA

  • Essayer de se connecter :

    • Par le bouton "Connexion" ;
    • En tentant d'accéder à une page dont l'accès est réservé aux membres (pour avoir un paramètre next ;
  • Avec et sans l'option "Se souvenir de moi".

  • Code relu et approuvé.

  • Ça fonctionne !

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 7, 2017

Coverage Status

Coverage remained the same at 88.878% when pulling 1f7a77f on rezemika:fix-4492 into 685568f on zestedesavoir:dev.

coveralls commented Aug 7, 2017

Coverage Status

Coverage remained the same at 88.878% when pulling 1f7a77f on rezemika:fix-4492 into 685568f on zestedesavoir:dev.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 7, 2017

Coverage Status

Coverage remained the same at 88.878% when pulling 86d44cb on rezemika:fix-4492 into 685568f on zestedesavoir:dev.

coveralls commented Aug 7, 2017

Coverage Status

Coverage remained the same at 88.878% when pulling 86d44cb on rezemika:fix-4492 into 685568f on zestedesavoir:dev.

@gcodeur gcodeur added this to the Version de développement milestone Aug 7, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 7, 2017

Coverage Status

Coverage decreased (-17.7%) to 55.468% when pulling 4bebe49 on rezemika:fix-4492 into 9a07f4b on zestedesavoir:dev.

coveralls commented Aug 7, 2017

Coverage Status

Coverage decreased (-17.7%) to 55.468% when pulling 4bebe49 on rezemika:fix-4492 into 9a07f4b on zestedesavoir:dev.

@pierre-24

This comment has been minimized.

Show comment
Hide comment
@pierre-24

pierre-24 Aug 7, 2017

Member

Y'a des erreurs introduite par ton dernier commit dans les tests. Une histoire de compairaison ;)

Member

pierre-24 commented Aug 7, 2017

Y'a des erreurs introduite par ton dernier commit dans les tests. Une histoire de compairaison ;)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 7, 2017

Coverage Status

Coverage decreased (-0.02%) to 88.853% when pulling 35a0f82 on rezemika:fix-4492 into 7e11628 on zestedesavoir:dev.

coveralls commented Aug 7, 2017

Coverage Status

Coverage decreased (-0.02%) to 88.853% when pulling 35a0f82 on rezemika:fix-4492 into 7e11628 on zestedesavoir:dev.

@pierre-24 pierre-24 merged commit d09f099 into zestedesavoir:dev Aug 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rezemika rezemika deleted the rezemika:fix-4492 branch Aug 7, 2017

sandhose added a commit that referenced this pull request Sep 18, 2017

Rend optionnel le champ 'Se souvenir de moi' dans le formulaire de co…
…nnexion (#4493)

* Rend optionnel le champ 'Se souvenir de moi'

* Corrige la variable 'LOGIN_URL'

* Corrige les tests

* Corrige des erreurs PEP-8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment