Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor la commande load_fixtures #4523

Merged
merged 3 commits into from Sep 22, 2017
Merged

Refactor la commande load_fixtures #4523

merged 3 commits into from Sep 22, 2017

Conversation

artragis
Copy link
Member

@artragis artragis commented Aug 13, 2017 •
edited

Q R
Type de modification évolution
Ticket(s) (issue(s)) concerné(s) #4373

QA

  • lancez python manage.py load_fixtures avec différents sets d'option
  • Code review

lorsque ça sera terminé, en settant l'option -q vous ne devriez pas voir d'output.

@coveralls
Copy link

Coverage Status

Coverage decreased (-33.7%) to 55.65% when pulling f760a3e on artragis:fix_4346 into 8662978 on zestedesavoir:dev.

@coveralls
Copy link

coveralls commented Aug 13, 2017 •
edited

Coverage Status

Coverage decreased (-15.8%) to 73.649% when pulling 799ee7c on artragis:fix_4346 into 8662978 on zestedesavoir:dev.

@pierre-24
Copy link
Member

Oublie pas de changer le Makefile :)

motet-a
motet-a reviewed Aug 13, 2017
View reviewed changes
doc/source/utils/fixture_loaders.rst Outdated
Vous pouvez ajouter ``racine`` qui permet de changer la base pour le nommage des utilisateurs (« user » par défaut).

Vous pouvez ajouter ``--racine`` qui permet de changer la base pour le nommage des utilisateurs (« user » par défaut).
Vous pouvez ne créer les éléments d'un module précis (ou de quelques-uns) via des options telles que ``--forum``. Ces options ne sont pas utilisables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ne manquerait-il pas un "que" dans cette phrase ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

si :)

@coveralls
Copy link

coveralls commented Aug 14, 2017 •
edited

Coverage Status

Coverage decreased (-15.8%) to 73.649% when pulling aa99c7d on artragis:fix_4346 into 8662978 on zestedesavoir:dev.

@motet-a motet-a added the C-Back Concerne le back-end Django label Aug 24, 2017
@motet-a
Copy link
Member

motet-a commented Sep 20, 2017

Lié à #4373.

@coveralls
Copy link

coveralls commented Sep 22, 2017 •
edited

Coverage Status

Coverage increased (+0.001%) to 89.483% when pulling c94d52a on artragis:fix_4346 into a7c078c on zestedesavoir:dev.

@artragis artragis changed the title [WIP]refactor la commande load_fixtures Refactor la commande load_fixtures Sep 22, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-33.9%) to 55.603% when pulling 4fc7c43 on artragis:fix_4346 into a7c078c on zestedesavoir:dev.

@coveralls
Copy link

coveralls commented Sep 22, 2017 •
edited

Coverage Status

Coverage decreased (-14.5%) to 75.011% when pulling 5f9cf5d on artragis:fix_4346 into a7c078c on zestedesavoir:dev.

@coveralls
Copy link

coveralls commented Sep 22, 2017 •
edited

Coverage Status

Coverage increased (+0.007%) to 89.489% when pulling 5dfb5f5 on artragis:fix_4346 into a7c078c on zestedesavoir:dev.

motet-a
motet-a approved these changes Sep 22, 2017
View reviewed changes
Copy link
Member

@motet-a motet-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

À part le fait que je trouve un peu étrange de désigner les entités par le mot “module”, LGTM.

@coveralls
Copy link

coveralls commented Sep 22, 2017 •
edited

Coverage Status

Coverage decreased (-0.008%) to 89.474% when pulling eaae596 on artragis:fix_4346 into a7c078c on zestedesavoir:dev.

@artragis
Copy link
Member Author

@motet-a j'ai changé le terme de "module" qui était en effet assez moche.

@artragis artragis added this to the Version de développement milestone Sep 22, 2017
@motet-a motet-a merged commit 35d5219 into zestedesavoir:dev Sep 22, 2017
@motet-a motet-a mentioned this pull request Sep 22, 2017
Closed
@gllmc gllmc mentioned this pull request Nov 21, 2017
Closed
@artragis artragis deleted the fix_4346 branch April 25, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motet-a motet-a motet-a approved these changes

Assignees
No one assigned
Labels
C-Back Concerne le back-end Django
Projects
None yet
Milestone
v26
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@artragis @coveralls @pierre-24 @motet-a