New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Member refactoring #4709

Closed
wants to merge 6 commits into
base: dev
from

Conversation

Projects
None yet
4 participants
@tleb
Contributor

tleb commented Oct 8, 2017

Suite de #4621 qui a encore des conflits avec dev, faut que je résolve ça.

Un peu toute la section membre a été impacté, c'est donc principalement du code review qui est nécessaire.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 8, 2017

Coverage Status

Coverage decreased (-33.9%) to 55.807% when pulling ee1d52e on tleb:member-refactoring into 99fe388 on zestedesavoir:dev.

coveralls commented Oct 8, 2017

Coverage Status

Coverage decreased (-33.9%) to 55.807% when pulling ee1d52e on tleb:member-refactoring into 99fe388 on zestedesavoir:dev.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 11, 2017

Coverage Status

Coverage decreased (-33.9%) to 55.81% when pulling 69bfe17 on tleb:member-refactoring into 3f0531a on zestedesavoir:dev.

coveralls commented Oct 11, 2017

Coverage Status

Coverage decreased (-33.9%) to 55.81% when pulling 69bfe17 on tleb:member-refactoring into 3f0531a on zestedesavoir:dev.

@gcodeur

Merci pour ton travail ! J'ai relevé quelques trucs à corriger. À voir aussi ce que disent Travis et Codacy.

Show outdated Hide outdated zds/member/decorator.py Outdated
for option in ['show_sign', 'is_hover_enabled', 'allow_temp_visual_changes',
'use_old_smileys', 'show_markdown_help', 'email_for_answer']:
if option in initial and initial[option]:
self.field['options'].initial += option

This comment has been minimized.

@gcodeur

gcodeur Oct 11, 2017

Member

👍

@gcodeur

gcodeur Oct 11, 2017

Member

👍

Show outdated Hide outdated zds/member/models.py Outdated
Show outdated Hide outdated zds/member/models.py Outdated
Show outdated Hide outdated zds/member/models.py Outdated
Show outdated Hide outdated zds/member/models.py Outdated
Show outdated Hide outdated zds/member/views.py Outdated
Show outdated Hide outdated zds/member/views.py Outdated
Show outdated Hide outdated zds/member/views.py Outdated
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 12, 2017

Coverage Status

Coverage decreased (-33.9%) to 55.81% when pulling 4aea929 on tleb:member-refactoring into 25d9f35 on zestedesavoir:dev.

coveralls commented Oct 12, 2017

Coverage Status

Coverage decreased (-33.9%) to 55.81% when pulling 4aea929 on tleb:member-refactoring into 25d9f35 on zestedesavoir:dev.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 12, 2017

Coverage Status

Coverage decreased (-33.9%) to 55.817% when pulling 164b7f7 on tleb:member-refactoring into 25d9f35 on zestedesavoir:dev.

coveralls commented Oct 12, 2017

Coverage Status

Coverage decreased (-33.9%) to 55.817% when pulling 164b7f7 on tleb:member-refactoring into 25d9f35 on zestedesavoir:dev.

@pierre-24

This comment has been minimized.

Show comment
Hide comment
@pierre-24

pierre-24 Aug 3, 2018

Member

Zut, c'est ireprenable, l'original a disparu :(

Member

pierre-24 commented Aug 3, 2018

Zut, c'est ireprenable, l'original a disparu :(

@pierre-24 pierre-24 closed this Aug 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment