Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default multiple selection behaviour for faux select #15

Merged
merged 5 commits into from Feb 27, 2018
Merged

Add default multiple selection behaviour for faux select #15

merged 5 commits into from Feb 27, 2018

Conversation

@amk221
Copy link
Contributor

amk221 commented Feb 27, 2018

When selecting an option in a faux-select which has multiple=true

The behaviour was undefined, and the select box just sent out ["the option"] an array with the option that was selected, just then.

Originally, the thinking behind this was that ember-select-box could not know what you wanted to happen. So left it up to you. But really, the majority of cases all want the same thing, and that is to add the option that was just selected to the selection.

Now, the default will be to add that option to the list of selected values if it's not already in there, and remove it if it is.

amk221 added 5 commits Feb 25, 2018
@amk221 amk221 merged commit 90bd381 into master Feb 27, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@amk221 amk221 deleted the beta5 branch Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.