Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build has changed the ProjectBuilder API in 1.0.0 #433

Closed
wosc opened this issue Sep 11, 2023 · 2 comments
Closed

build has changed the ProjectBuilder API in 1.0.0 #433

wosc opened this issue Sep 11, 2023 · 2 comments

Comments

@wosc
Copy link

wosc commented Sep 11, 2023 •
edited
Loading 

File "/srv/jenkins/.local/share/virtualenvs/bin-RMo-sxFa/lib/python3.11/site-packages/zest/releaser/release.py", line 150, in _upload_distributions
    builder = ProjectBuilder(srcdir=".", runner=_project_builder_runner)
TypeError: ProjectBuilder.__init__() got an unexpected keyword argument 'srcdir'

AFACT this happend in build 1.0.0, or more precisely in this PR

Pinning build < 1.0.0 can be done as a workaround for now, but I guess zest.releaser will need to update its usage.
@matthewhegarty
Copy link

I had to add this to my requirements file: zest.releaser < 9.0.0

mauritsvanrees added a commit that referenced this issue Oct 3, 2023
@mauritsvanrees
Merge pull request #435 from zestsoftware/reinout-fix-build
18a7044 
Using newer 'build' including slight API change, fixes #433
@reinout
Copy link
Collaborator

reinout commented Oct 3, 2023

I've released 9.1.0 with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reinout @wosc @matthewhegarty