Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media module does not show Upload button if field is locked to a group #482

Closed
giseleblair opened this issue Feb 3, 2021 · 9 comments · Fixed by #1389
Closed

Media module does not show Upload button if field is locked to a group #482

giseleblair opened this issue Feb 3, 2021 · 9 comments · Fixed by #1389
Assignees
Labels
bug Something isn't working

Comments

@giseleblair
Copy link
Contributor

Describe the bug
If a content field has been previously locked to a media group, its media module does not show the upload button.

To Reproduce
Steps to reproduce the behavior:

  1. Go to an instance with a content field that is locked to a group. See internal ticket for more details: https://zestysupport.zendesk.com/agent/tickets/1167
  2. Click on media field in the content item to open the media module
  3. See the module does not display "Upload" button

Expected behavior
Expect to see the upload button just like when an unlocked media module is displaying.

Screenshots
IMG_0121

Desktop (please complete the following information):

  • OS:MacOS Big Sur
  • Browser: Safari & Chrome

Additional context
This was reported by a client who was confused as to how to upload media. The drag & drop option is still available but it is not intuitive. An upload button would have helped relieve the confusion as well as some instruction about the drag & drop function.

@giseleblair giseleblair added bug Something isn't working app: media labels Feb 3, 2021
@nibblebot
Copy link
Contributor

Do we want to move the Upload button to the Header and out of the Sidebar? @shrunyan

@nibblebot
Copy link
Contributor

bump @shrunyan I think we should consider moving Upload button to the Header

@d88naimi
Copy link
Contributor

d88naimi commented Jan 3, 2022

This looks like it has been resolved with the upload button now in the header.

@giseleblair can you confirm you are seeing the same results?

Screen Shot 2022-01-03 at 3 58 00 PM

@d88naimi d88naimi closed this as completed Jan 3, 2022
@giseleblair
Copy link
Contributor Author

@d88naimi This has not been resolved. The modal still does not show the Upload button if a field is tied to a group.
Screen Shot 2022-01-18 at 5 00 42 PM

@d88naimi
Copy link
Contributor

@giseleblair can you upload a video as I was testing a locked image group and my workflow must be off.

@d88naimi d88naimi reopened this Jan 18, 2022
@giseleblair
Copy link
Contributor Author

here you go: https://www.loom.com/share/ac59a867eddb45ba96dc061066da5fe6

@d88naimi d88naimi assigned d88naimi and unassigned nibblebot Jan 18, 2022
@d88naimi
Copy link
Contributor

@shrunyan I believe we were hiding the upload and sidebar on purpose in media to prevent users from altering a locked group which was causing a crash if I am not mistaken?

https://github.com/zesty-io/manager-ui/blob/master/src/apps/media/src/app/MediaApp.js#L197-L209

@giseleblair
Copy link
Contributor Author

Users can still upload media to the group by dragging and dropping. It is not immediately obvious to the user that they can drag and drop images and the upload button was useful in that case. (See the "Additional Context" in the original issue post)

@agalin920
Copy link
Contributor

Given the fact that "Drag and Drop" is never evident my solution for this is adding in some helper text.

Screen Shot 2022-09-28 at 9 47 37 AM

@agalin920 agalin920 linked a pull request Sep 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
5 participants