-
Notifications
You must be signed in to change notification settings - Fork 60
onAbort support
#248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onAbort support
#248
Conversation
📝 WalkthroughWalkthroughThis pull request introduces a new abort-handling feature in the Universal contract by adding an Changes
Sequence Diagram(s)sequenceDiagram
participant Gateway
participant UniversalContract
Gateway->>UniversalContract: Call onAbort(context)
Note over UniversalContract: Verify caller is gateway
UniversalContract-->>Gateway: Emit AbortEvent(context)
sequenceDiagram
participant User
participant TaskScript
participant Contract
User->>TaskScript: Invoke task with abortAddress argument
TaskScript->>TaskScript: Set revertOptions.abortAddress = args.abortAddress
TaskScript->>Contract: Execute transaction with custom abortAddress
Possibly related PRs
Suggested Reviewers
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🔇 Additional comments (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@zeta-chain/smart-contracts please, review. |
s2imonovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
|
@s2imonovic please, leave an approval if everything's ok, so I can merge. Thanks! |
s2imonovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Summary by CodeRabbit
New Features
Chores
@zetachain/localnetdependency to version7.1.0.@zetachain/protocol-contractsdependency to version12.0.0-rc1.@zetachain/protocol-contractsdependency in the swap example.