Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User names and passwords can contain spaces. #51

Closed
JeffVeit opened this Issue Sep 16, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@JeffVeit
Copy link

JeffVeit commented Sep 16, 2016

I'm working with imap, but the same is true of pop3 and smtp... when a user tries to authenticate, user names may contain spaces. That means that for imap, using LOGIN user pass will fail. The solution is to quote the username and password.

For imap in imap_transport.php, the line should become
$this->connection->sendData( "{$tag} LOGIN "{$user}" "{$password}"" );

It might be a good idea to only include quotes when $user or $password has spaces.

Tested on gmail and it works as above.

@derickr

This comment has been minimized.

Copy link
Member

derickr commented Sep 19, 2016

You're probably correct that this change needs to be made, but as the test suite is currently not correctly working, I am reluctant to just make this change at this moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.