Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #51 User names and passwords can contain spaces. #70

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mfb
Copy link
Contributor

mfb commented Feb 11, 2019

Passwords need to be quoted since they may contain spaces (and any double-quote or backslash need to be escaped with backslash).

Note: I have a feeling this library doesn't correctly handle non-ASCII characters in password.. but I didn't try to tackle that in this PR :)

derickr added a commit that referenced this pull request Feb 13, 2019

@derickr

This comment has been minimized.

Copy link
Member

derickr commented Feb 13, 2019

Merged (After rebase). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.