Charset for postgreSQL DB-adapter is not valid #184

Merged
merged 3 commits into from Jun 2, 2014

Projects

None yet

2 participants

@gartner
Contributor
gartner commented May 30, 2014

Charset in connection-settings when using Pdo_pgsql is not valid.

As long as you do not enter anything in the charset-field when creating the adapter, all is good.
But, entering a charset, save it, and the adapter will fail with an exception, since, charset is not a valid conneciton-setting.

But if you then delete the contents of the charset-field again, it is still saved in the connection-settings for the adapter, making it fail to connect still.

weierophinney added some commits Jun 2, 2014
@weierophinney weierophinney [#184] Do not save charset for Pgsql adapters
- If the adapter is for postgres, do not save the charset option, either during
  creation or update.
56417d0
@weierophinney weierophinney [#184] Do not display charset option for Postgres
- If the driver selected is Postgres, do not display the charset option.
7d1f024
@weierophinney weierophinney Rebuilt UI distribution 90f1e16
@weierophinney weierophinney added this to the 1.0.2 milestone Jun 2, 2014
@weierophinney weierophinney merged commit 90f1e16 into zfcampus:master Jun 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@weierophinney weierophinney added a commit that referenced this pull request Jun 2, 2014
@weierophinney weierophinney Merge branch 'hotfix/184'
Close #184
69e05ae
@weierophinney weierophinney added a commit that referenced this pull request Jun 2, 2014
@weierophinney weierophinney Merge branch 'hotfix/184' into develop
Forward port #184
d1262b1
@weierophinney weierophinney deleted the weierophinney:hotfix/184 branch Jun 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment