Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jun 21, 2011
  1. client/common_lib/hosts/base_classes.py: Unify host up/down timeouts …

    lmr authored
    …and expose in global_config
    
    Confusingly, timeouts for the same thing are set differently in multiple
    places. Also, many of the host timeouts are far too long for Chrome OS.
    As such, I've unified a couple of the host timeouts and exposed the
    default values through global config.
    
    Signed-off-by: Dale Curtis <dalecurtis@google.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5434 592f7852-d20e-0410-864c-8624ca9c26a4
  2. server/crashcollect.py: Add control for crash collection timeout to g…

    lmr authored
    …lobal_config
    
    The four hour timeout for crash collection is way too long for Chrome
    OS, so we moved this parameter into global config for easier control.
    
    Signed-off-by: Dale Curtis <dalecurtis@google.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5433 592f7852-d20e-0410-864c-8624ca9c26a4
  3. server/hosts/abstract_ssh.py: Allow for site extension of base ssh co…

    lmr authored
    …mmand
    
    There have been several cases where we need to modify the SSH command
    line for Chrome OS. This patch adds site extensibility to the
    make_ssh_command function in abstract_ssh.
    
    Signed-off-by: Dale Curtis <dalecurtis@google.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5432 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on May 25, 2011
  1. server/autotest.py: Fixing a couple of minor exception formatting errors

    lmr authored
    Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5379 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Apr 19, 2011
  1. Fixed unit test for server/autotest.py

    lmr authored
    Fix unit test for server/autotest.py broke in r5317.
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5323 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Apr 18, 2011
  1. server/autotest.py: Refactor code for site modification

    lmr authored
    I need to override the logic to read fetch_location from global_config with
    site_autotest implementation. So I refactored it out to its own function
    inside server/autotest.py.
    
    Signed-off-by: Eric Li <ericli@google.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5317 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Mar 24, 2011
  1. job: Remove non-existant parameter on generate_control_file calls (Fi…

    lmr authored
    …x #47)
    
    Since its introduction on r2440, server/frontend.py has a call to
    generate_control_file, present on frontend/afe/rpc_interface.py.
    This method apparently never had a do_push_packages parameter,
    but for some reason we were passing it in case we provide a specific
    kernel with -k. Remove all references to do_push_packages.
    
    With this, bug #47 is fixed, and it is possible to specify -k through
    the cli.
    
    Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5287 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Feb 21, 2011
  1. Fix Wrong 4th argument in call to self.job.record()

    lmr authored
    Signed-off-by: Jongki Suwandi <jsuwandi@google.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5257 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Feb 16, 2011
  1. Fixed hardcoded "four hours" info message

    lmr authored
    Signed-off-by: Jongki Suwandi <jsuwandi@google.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5233 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Feb 4, 2011
  1. IGTTOU was causing a hang in terminals with tostop set (which seems t…

    ericli authored
    …o be the default for my local emacs configuration).
    
    Signed-off-by: David Rochberg (rochberg@chromium.org)
    BUG=chromiumos:7716
    TEST=stty tostop, then run with and without this change.  Without the change, tests will hang in a SIGTTOU/syscall-restarted loop.
    
    Change-Id: Ib5317e238b68089d71e8e57418717e7553fd64d9
    
    Review URL: http://codereview.chromium.org/6368022
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5216 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Jan 6, 2011
  1. autoserv: improve command-line error handling

    lmr authored
    I got confused by the error messages printed by autoserv when I tried to
    use it, so I tried to improve it a little bit.
    
    Instead of printing error messages to stdout (and sometimes simply
    dumping help text without any explanation), use the OptionParse.error()
    method that aborts the program automatically after printing a short
    command-line help text and an error message.
    
    Signed-off-by: Eduardo Habkost <ehabkost@raisama.net>
    
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5067 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Dec 28, 2010
  1. server: fix logfile following to use ssh username and port

    lmr authored
    The current logging code assumes that 'root' can be used to log
    into the client machine, which isn't always the case.  This patch
    makes the logger user the user and port settings saved in the
    host object.
    
    This patch also removes the used-exactly-once run_cmd_on_host() function
    and inlined it since it doesn't seem like there is any benefit to splitting
    it out.  It instead adds a _make_ssh_cmd() method to the abstract_ssh
    class which respects the username and port settings.
    
    It also eliminates the redirection of stderr from the subprocess.Popen()
    call.  If the command fails, then I want to see the output appear in
    the log.
    
    Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5011 592f7852-d20e-0410-864c-8624ca9c26a4
  2. server: Only use client autotest directory if it is writable

    lmr authored
    When using an unprivileged account on a client, need to make sure that
    the autotest directory is actually writable before trying to use it.
    Otherwise the test will fail.
    
    This problem was encountered when trying to use an unprivileged
    account on the same machine as the autotest server (to use it for
    running builds).  Without this patch, autotest would try to delete the
    server files while installing the needed client side files in
    /usr/local/autotest.
    
    Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5010 592f7852-d20e-0410-864c-8624ca9c26a4
  3. server: Store copy of /var/log/messages into /var/tmp instead

    lmr authored
    When connecting to an unprivileged account on a client, /var/lib will
    not be writable.  Store the snapshot of /var/log/messages in /var/tmp
    instead which is far more likely to be writable.
    
    v2:
    - Moved storage location from /tmp to /var/tmp so that it survives over
      reboot
    
    Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5009 592f7852-d20e-0410-864c-8624ca9c26a4
  4. server: simplify parse_machine and add a test case

    lmr authored
    This patch simplifies the implementation of base_utils.parse_machine()
    and adds test cases to make sure it is parsing strings correctly.
    
    v2:
    - Reordered with 'server: user parse_machine directly inside
      create_host()' to avoid creating an non-bisectable commit.
    - modified code to use the form "if '@' in string:" which is clearer
    
    Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5008 592f7852-d20e-0410-864c-8624ca9c26a4
  5. server: use parse_machine directly inside create_host()

    lmr authored
    Currently, parse_machine() is called explicitly by the
    control_segments hooks before calling create_host, but is not used by
    anything else which means that a machine that is specified in
    [user[:pass]@]host[:port] format will not get the username, password
    and port preferences applied consistently (the hooks will use it
    correctly, but other connections will not).
    
    This patch moves the call to parse_machine directly inside create_host
    so that all references to clients can also specify a
    username/port/password (for instance, in the server's list of hosts).
    
    At the same time, reorder the arguments so it emits the values in the
    same order that they are passed.
    
    v2:
    - reordered with 'server: simplify parse_machine ...'
    - fixed non-bisectable commit by fixing return result order
    - cleaned up spacing around '=' in keyword arguments
    
    Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5007 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Dec 21, 2010
  1. server/hosts/remote.py: Look for the previous boot_id in all cases

    lmr authored
    Signed-off-by: Jean-Marc Eurin <jmeurin@google.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@5000 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Nov 27, 2010
  1. Making the barrier test work on the server

    lmr authored
    Signed-off-by: Jean-Marc Eurin <jmeurin@google.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4965 592f7852-d20e-0410-864c-8624ca9c26a4
  2. Cleaning up and using the base code for the host

    lmr authored
    Cleaning up and using the base code for the host.
    In the profiler code, the hostid should be a hostname.
    Added some client barrier tests and unittests.
    
    Signed-off-by: Jean-Marc Eurin <jmeurin@google.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4964 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Nov 24, 2010
  1. pass SSH options into SSHHost

    lmr authored
    We found the previous patch only fixed a part of our problem. We just found
    there are occurrences inside server test control files which called
    hosts.create_host(hostname) without properly passed in ssh options. And I do
    not want to touch the test control files at all.
    
    So here is a solution, my previous changes to SSHHost is reverted in this
    patch, since it is not necessary any more.
    I tested this change with both client and server side sleeptest against a
    remote VM ( on port other than 22).
    
    Signed-off-by: Eric Li <ericli@google.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4944 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Nov 22, 2010
  1. pass SSH options into SSHHost

    lmr authored
    When we started using autotest to run test against a VM based chromium os,
    we found autotest was not able to handle ssh port other than 22, autoserv
    --ssh-port did not work as it suppose to.
    
    It turned our the ssh options were not properly passed into SSHHost class.
    
    Signed-off-by: Eric Li <ericli@google.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4939 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Nov 11, 2010
  1. Adds a barriertest_2client server side test that tests barrier

    lmr authored
    Adds a barriertest_2client server side test that tests barrier
    functionality between two client tests without any server involvement.
    
    Signed-off-by: Gregory Smith <gps@google.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4919 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Nov 8, 2010
  1. Adding the drone to the keyval file

    lmr authored
    Signed-off-by: Jean-Marc Eurin <jmeurin@google.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4908 592f7852-d20e-0410-864c-8624ca9c26a4
  2. Massive permission and indentation fix on the autotest tree

    lmr authored
    Once again I went through the autotest tree with my automated script to
    check all autotest source, and discovered several places that needed
    permission and indentation (including trailing whitespace) fixes. I have
    checked the generated patch and indeed it looks OK. Will commit this
    shortly, as preparation for autotest 0.13.
    
    Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4907 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Oct 19, 2010
  1. server/frontend.py: Add support for passing in a kernel command line

    lmr authored
    Signed-off-by: Gregory Smith <gps@google.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4872 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Oct 12, 2010
  1. server/git_kernel.py - Allow to specify a builddir for GitKernel

    lmr authored
    Make it possible to specify a builddir for the install() method
    of the GitKernel class.
    
    Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4847 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Oct 8, 2010
  1. Replicate the weburl default set on the GitKernel class

    lmr authored
    So people don't have to actually provide the weburl in
    control files.
    
    Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4845 592f7852-d20e-0410-864c-8624ca9c26a4
  2. server/git_kernel.py: Revert change made on r4811

    lmr authored
    Turns out it was wrong.
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4844 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Oct 6, 2010
  1. Fix use of rsync in server/hosts/abstract_ssh.py

    lmr authored
    This patch fixes a long, long standing bug (in fact, I
    started to dig and gave up when I looked the last 5
    changes to the file, dating 8 months ago): The method
    use_rsync(), used to verify whether autotest should
    be copied to the client using scp or rsync does not
    return in case we detect that the client machine does
    have rsync installed, so the first use_rsync() check
    will allways return None. Subsequent checks will
    return True because during the first run an attribute
    will be set to True, making the function return properly.
    
    Bottom line, we will *allways* end up copying all the
    client code to the client machine using scp instead of rsync,
    which should be way faster after the 1st time the client
    got copied to the machine. We probably didn't notice this
    because:
    
    1) Most of the time we'll run with the key
    
    [PACKAGES]
    serve_packages_from_autoserv: True
    
    Which makes the amount of data being copied way smaller,
    so we won't bother
    
    2) Other times we'd be installing the client using the
    packaging system.
    
    Anyway, it's a bug, should be fixed and will probably
    help people using autoserv to install autotest in remote
    machines (as I was doing this week :))
    
    Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4820 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Sep 26, 2010
  1. server/git_kernel.py - Use the correct base directory

    lmr authored
    The original code of git_kernel.py was attributing an
    incorrect path to the source code directory in the
    client. Fixing that.
    
    Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4811 592f7852-d20e-0410-864c-8624ca9c26a4
  2. server/git_kernel.py - Fix __init__ call in GitKernel

    lmr authored
    During the change made on r4792, I (lmr) forgot to
    change the call to the git parent class to use super().
    Let's fix that.
    
    Signed-off-by: Frank Becker <fb@alien8.de>
    Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4810 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Sep 16, 2010
  1. [PATCH] Read all labels from host_keyvals file and handle the comma

    ericli authored
    (,) within labels properly.
    
    Chromium OS autotest project had assigned labels with comma to test hosts
    and this situation makes the current host_keyvals file impossible to parse
    out correct label values. This change will fix/enhance that.
    
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4793 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Sep 15, 2010
  1. Introduce common_lib.revision_control

    lmr authored
    Introduce a library with classes to abstract interaction
    with version control system repositories. Right now, there is
    only GitRepo implemented. Made server/git.py to use the
    common_lib implementation (the server git class represents
    the install of a git repo in a host).
    
    Now, test writers and can use a shared API to check out and
    update git code conveniently.
    
    Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4792 592f7852-d20e-0410-864c-8624ca9c26a4
Commits on Sep 14, 2010
  1. Fix for r4780 - server/git.py GitRepo extension

    lmr authored
    Fix for my last patch (r4780). Thanks to John Admanski
    <jadmanski@google.com>.
    
    Signed-off-by: Frank Becker <fb@alien8.de>
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4786 592f7852-d20e-0410-864c-8624ca9c26a4
  2. Add support to the parser and server job for logging the result of an…

    jadmanski authored
    … exception
    
    when it is raised within the server control file and not inside of a job.
    Currently these exceptions are only logged into the debug/ logs and not into
    the status log (and thus not into the database).
    
    It adds support by logging an INFO message with a special job_abort_reason
    field when a server job fails with an exception, and the parser then
    special-cases these info lines (much like it already does with kernel version
    INFO lines) and updates the SERVER_JOB entry.
    
    Unfortunately this can't easily be done with a "normal" status log entry since
    when a failure occurs outside of a test the special SERVER_JOB entry is the
    only place where this reason information actually belongs, but the parser has
    no existing mechanism for modifying this entry (since it's automatically
    generated by the parser, rather than being generated in response to a specific
    log). Adding this (relatively small) special case seemed more practical than
    either adding yet another special entry or trying to perform a major
    restructuring of the parser.
    
    Signed-off-by: John Admanski <jadmanski@google.com>
    
    
    
    git-svn-id: svn://test.kernel.org/autotest/trunk@4785 592f7852-d20e-0410-864c-8624ca9c26a4
Something went wrong with that request. Please try again.