Skip to content
Permalink
Browse files

add regression test for "zpool list -p"

Signed-off-by: Paul Dagnelie <pcd@delphix.com>
  • Loading branch information...
prakashsurya authored and pcd1193182 committed Nov 14, 2014
1 parent c81f179 commit 40749f3661c5e491cd2ce37d8e07ec95c8e0eb0f
@@ -360,7 +360,7 @@ tags = ['functional', 'cli_root', 'zpool_export']

[tests/functional/cli_root/zpool_get]
tests = ['zpool_get_001_pos', 'zpool_get_002_pos', 'zpool_get_003_pos',
'zpool_get_004_neg']
'zpool_get_004_neg', 'zpool_get_005_pos']
tags = ['functional', 'cli_root', 'zpool_get']

[tests/functional/cli_root/zpool_history]
@@ -5,7 +5,8 @@ dist_pkgdata_SCRIPTS = \
zpool_get_001_pos.ksh \
zpool_get_002_pos.ksh \
zpool_get_003_pos.ksh \
zpool_get_004_neg.ksh
zpool_get_004_neg.ksh \
zpool_get_005_pos.ksh

dist_pkgdata_DATA = \
zpool_get.cfg
zpool_get.cfg zpool_get_parsable.cfg
@@ -0,0 +1,77 @@
#!/usr/bin/ksh -p
#
# CDDL HEADER START
#
# The contents of this file are subject to the terms of the
# Common Development and Distribution License (the "License").
# You may not use this file except in compliance with the License.
#
# You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
# or http://www.opensolaris.org/os/licensing.
# See the License for the specific language governing permissions
# and limitations under the License.
#
# When distributing Covered Code, include this CDDL HEADER in each
# file and include the License file at usr/src/OPENSOLARIS.LICENSE.
# If applicable, add the following below this CDDL HEADER, with the
# fields enclosed by brackets "[]" replaced with your own identifying
# information: Portions Copyright [yyyy] [name of copyright owner]
#
# CDDL HEADER END
#

#
# Copyright 2008 Sun Microsystems, Inc. All rights reserved.
# Use is subject to license terms.
#

#
# Copyright (c) 2014 by Delphix. All rights reserved.
#

. $STF_SUITE/include/libtest.shlib
. $STF_SUITE/tests/functional/cli_root/zpool_get/zpool_get_parsable.cfg

#
# DESCRIPTION:
#
# Zpool get returns parsable values for all known parsable properties
#
# STRATEGY:
# 1. For all parsable properties, verify zpool get -p returns a parsable value
#

if ! is_global_zone ; then
TESTPOOL=${TESTPOOL%%/*}
fi

typeset -i i=0

while [[ $i -lt "${#properties[@]}" ]]; do
log_note "Checking for parsable ${properties[$i]} property"
log_must eval "zpool get -p ${properties[$i]} $TESTPOOL >/tmp/value.$$"
grep "${properties[$i]}" /tmp/value.$$ >/dev/null 2>&1
if [[ $? -ne 0 ]]; then
log_fail "${properties[$i]} not seen in output"
fi

typeset v=$(grep "${properties[$i]}" /tmp/value.$$ | $AWK '{print $3}')

log_note "${properties[$i]} has a value of $v"

# Determine if this value is a valid number, result in return code
expr $v + 0 >/dev/null 2>&1

# All properties must be positive integers in order to be
# parsable (i.e. a return code of 0 or 1 from expr above).
# The only exception is "expandsize", which may be "-".
if [[ ! ($? -eq 0 || $? -eq 1 || \
("${properties[$i]}" = "expandsize" && "$v" = "-")) ]]; then
log_fail "${properties[$i]} is not parsable"
fi

i=$(( $i + 1 ))
done

rm /tmp/value.$$
log_pass "Zpool get returns parsable values for all known parsable properties"
@@ -0,0 +1,33 @@
#
# CDDL HEADER START
#
# The contents of this file are subject to the terms of the
# Common Development and Distribution License (the "License").
# You may not use this file except in compliance with the License.
#
# You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
# or http://www.opensolaris.org/os/licensing.
# See the License for the specific language governing permissions
# and limitations under the License.
#
# When distributing Covered Code, include this CDDL HEADER in each
# file and include the License file at usr/src/OPENSOLARIS.LICENSE.
# If applicable, add the following below this CDDL HEADER, with the
# fields enclosed by brackets "[]" replaced with your own identifying
# information: Portions Copyright [yyyy] [name of copyright owner]
#
# CDDL HEADER END
#

#
# Copyright 2009 Sun Microsystems, Inc. All rights reserved.
# Use is subject to license terms.
#

#
# Copyright (c) 2013, 2014 by Delphix. All rights reserved.
#

# Set the expected properties of zpool
typeset -a properties=("allocated" "capacity" "expandsize" "free" "freeing"
"leaked" "size")

0 comments on commit 40749f3

Please sign in to comment.
You can’t perform that action at this time.