Skip to content
Permalink
Browse files

Don't hard-code number of ioctls for portability

Use (ZFS_IOC_LAST - ZFS_IOC_FIRST) instead of 256.
It seems 256 is just a number large enough to hold ioctls
at the moment.

Using 256 also causes compile-time warning or error
on platfoms whose enum zfs_ioc definition differs.

Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes #8598
  • Loading branch information...
kusumi authored and behlendorf committed Apr 7, 2019
1 parent 96e51d2 commit 703f791d3538472600571ecde01627df6b47e6d6
Showing with 1 addition and 1 deletion.
  1. +1 −1 tests/zfs-tests/cmd/libzfs_input_check/libzfs_input_check.c
@@ -37,7 +37,7 @@ const char *active_test;
/*
* Tracks which zfs_ioc_t commands were tested
*/
boolean_t ioc_tested[256];
boolean_t ioc_tested[ZFS_IOC_LAST - ZFS_IOC_FIRST];

/*
* Legacy ioctls that are skipped (for now)

0 comments on commit 703f791

Please sign in to comment.
You can’t perform that action at this time.