Permalink
Browse files

Move assert in dump_dir() in zdb

This one line patch moves an assert in the function dump_dir()
below an error check that ensures it ran correctly. This ensures
zdb dumps the error that actually caused the problem, as opposed
to one of its symptoms.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #8171
  • Loading branch information...
tcaputi authored and behlendorf committed Dec 5, 2018
1 parent 78e2139 commit e3c85c0938c5d878927fcb812792b68fd056b188
Showing with 3 additions and 3 deletions.
  1. +3 −3 cmd/zdb/zdb.c
@@ -2522,15 +2522,15 @@ dump_dir(objset_t *os)
(void) printf("\tPercent empty: %10lf\n",
(double)(max_slot_used - total_slots_used)*100 /
(double)max_slot_used);
ASSERT3U(object_count, ==, usedobjs);
(void) printf("\n");
if (error != ESRCH) {
(void) fprintf(stderr, "dmu_object_next() = %d\n", error);
abort();
}
ASSERT3U(object_count, ==, usedobjs);
if (leaked_objects != 0) {
(void) printf("%d potentially leaked objects detected\n",
leaked_objects);

0 comments on commit e3c85c0

Please sign in to comment.