New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile failure on Ubuntu Karmic x64 #18

Closed
ghstridr opened this Issue Jun 4, 2010 · 7 comments

Comments

Projects
None yet
5 participants
@ghstridr

ghstridr commented Jun 4, 2010

cc1: warnings being treated as errors
/root/zfs-kernel/zfs-0.4.9/module/zfs/dsl_deleg.c: In function ‘dsl_deleg_get’:
/root/zfs-kernel/zfs-0.4.9/module/zfs/dsl_deleg.c:364: error: the frame size of 1040 bytes is larger than 1024 bytes
make[5]: *** [/root/zfs-kernel/zfs-0.4.9/module/zfs/dsl_deleg.o] Error 1
make[4]: *** [/root/zfs-kernel/zfs-0.4.9/module/zfs] Error 2
make[3]: *** [module/root/zfs-kernel/zfs-0.4.9/module] Error 2
make[3]: Leaving directory /usr/src/linux-headers-2.6.31-14-server' make[2]: *** [modules] Error 2 make[2]: Leaving directory/root/zfs-kernel/zfs-0.4.9/module'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/root/zfs-kernel/zfs-0.4.9'
make: *** [all] Error 2

@ghstridr

This comment has been minimized.

Show comment
Hide comment
@ghstridr

ghstridr Jun 4, 2010

spl compiles fine and installs into the kernel.

ghstridr commented Jun 4, 2010

spl compiles fine and installs into the kernel.

@behlendorf

This comment has been minimized.

Show comment
Hide comment
@behlendorf

behlendorf Jun 4, 2010

Member

Interesting it looks like under Ubuntu Karmic the maximum kernel stack frame size has been dropped from 2048 to 1024 bytes. It's correctly flagging the dsl_deleg_get() function as stack heavy. I'll make sure this get's addressed in the next release. This isn't the first place I've found stack size/depth issues.

Member

behlendorf commented Jun 4, 2010

Interesting it looks like under Ubuntu Karmic the maximum kernel stack frame size has been dropped from 2048 to 1024 bytes. It's correctly flagging the dsl_deleg_get() function as stack heavy. I'll make sure this get's addressed in the next release. This isn't the first place I've found stack size/depth issues.

@Saiyine

This comment has been minimized.

Show comment
Hide comment
@Saiyine

Saiyine Jun 5, 2010

Confirmed also in Lucid Lynx x64.

Saiyine commented Jun 5, 2010

Confirmed also in Lucid Lynx x64.

@laxmanpradhan

This comment has been minimized.

Show comment
Hide comment
@laxmanpradhan

laxmanpradhan Jun 9, 2010

I can also confirm build problems on Ubuntu 10.04 64 bit (Virtual Box). SPL compiled and splat regression tests all passed. ZFS rpm build failed. Same problem as above.
CC [M] /tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module/zfs/dsl_dataset.o
CC [M] /tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module/zfs/dsl_deleg.o
cc1: warnings being treated as errors
/tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module/zfs/dsl_deleg.c: In function ‘dsl_deleg_get’:
/tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module/zfs/dsl_deleg.c:364: error: the frame size of 1040 bytes is larger than 1024 bytes
make[7]: *** [/tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module/zfs/dsl_deleg.o] Error 1
make[6]: *** [/tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module/zfs] Error 2
make[5]: *** [module/tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module] Error 2
make[5]: Leaving directory /usr/src/linux-headers-2.6.32-21-generic' make[4]: *** [modules] Error 2 make[4]: Leaving directory/tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory /tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9' make[2]: *** [all] Error 2 make[2]: Leaving directory/tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9'
error: Bad exit status from /tmp/zfs-build-manager-ESirXxYS/TMP/rpm-tmp.4ZiiLL (%build)

RPM build errors:
Bad exit status from /tmp/zfs-build-manager-ESirXxYS/TMP/rpm-tmp.4ZiiLL (%build)
make[1]: *** [rpm-common] Error 1
make[1]: Leaving directory `/usr/src/zfs'
make: *** [rpm-modules] Error 2

laxmanpradhan commented Jun 9, 2010

I can also confirm build problems on Ubuntu 10.04 64 bit (Virtual Box). SPL compiled and splat regression tests all passed. ZFS rpm build failed. Same problem as above.
CC [M] /tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module/zfs/dsl_dataset.o
CC [M] /tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module/zfs/dsl_deleg.o
cc1: warnings being treated as errors
/tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module/zfs/dsl_deleg.c: In function ‘dsl_deleg_get’:
/tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module/zfs/dsl_deleg.c:364: error: the frame size of 1040 bytes is larger than 1024 bytes
make[7]: *** [/tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module/zfs/dsl_deleg.o] Error 1
make[6]: *** [/tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module/zfs] Error 2
make[5]: *** [module/tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module] Error 2
make[5]: Leaving directory /usr/src/linux-headers-2.6.32-21-generic' make[4]: *** [modules] Error 2 make[4]: Leaving directory/tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9/module'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory /tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9' make[2]: *** [all] Error 2 make[2]: Leaving directory/tmp/zfs-build-manager-ESirXxYS/BUILD/zfs-0.4.9'
error: Bad exit status from /tmp/zfs-build-manager-ESirXxYS/TMP/rpm-tmp.4ZiiLL (%build)

RPM build errors:
Bad exit status from /tmp/zfs-build-manager-ESirXxYS/TMP/rpm-tmp.4ZiiLL (%build)
make[1]: *** [rpm-common] Error 1
make[1]: Leaving directory `/usr/src/zfs'
make: *** [rpm-modules] Error 2

@belarm

This comment has been minimized.

Show comment
Hide comment
@belarm

belarm Jun 16, 2010

I was able to get zfs to compile despite this issue by adding '-fno-stack-protector' to EXTRA_CFLAGS in the modules/zfs Makefile. I cannot speak to the safety of this, however - I'm still getting everything set up.

belarm commented Jun 16, 2010

I was able to get zfs to compile despite this issue by adding '-fno-stack-protector' to EXTRA_CFLAGS in the modules/zfs Makefile. I cannot speak to the safety of this, however - I'm still getting everything set up.

@behlendorf

This comment has been minimized.

Show comment
Hide comment
@behlendorf

behlendorf Jun 16, 2010

Member

Great, using '-fno-stack-protector' is safe for this since we already know we won't overflow the stack. I have a better fix for this in my local tree which I hope to push fairly soon. I've been bogged down working through the issues of updating the code base to the latest opensolaris sources.

Member

behlendorf commented Jun 16, 2010

Great, using '-fno-stack-protector' is safe for this since we already know we won't overflow the stack. I have a better fix for this in my local tree which I hope to push fairly soon. I've been bogged down working through the issues of updating the code base to the latest opensolaris sources.

@behlendorf

This comment has been minimized.

Show comment
Hide comment
@behlendorf

behlendorf Jul 2, 2010

Member

This build issue was fixed by commit 869764f in the latest source.

Member

behlendorf commented Jul 2, 2010

This build issue was fixed by commit 869764f in the latest source.

This was referenced Apr 19, 2012

akatrevorjay added a commit to akatrevorjay/zfs that referenced this issue Dec 16, 2017

# This is a combination of 56 commits.
# This is the 1st commit message:
Merge branch 'master' of https://github.com/zfsonlinux/zfs

* 'master' of https://github.com/zfsonlinux/zfs:
  Enable QAT support in zfs-dkms RPM

# This is the commit message zfsonlinux#2:

Import 0.6.5.7-0ubuntu3

# This is the commit message zfsonlinux#3:

gbp changes

# This is the commit message zfsonlinux#4:

Bump ver

# This is the commit message zfsonlinux#5:

-j9 baby

# This is the commit message zfsonlinux#6:

Up

# This is the commit message zfsonlinux#7:

Yup

# This is the commit message zfsonlinux#8:

Add new module

# This is the commit message zfsonlinux#9:

Up

# This is the commit message zfsonlinux#10:

Up

# This is the commit message zfsonlinux#11:

Bump

# This is the commit message zfsonlinux#12:

Grr

# This is the commit message zfsonlinux#13:

Yay

# This is the commit message zfsonlinux#14:

Yay

# This is the commit message zfsonlinux#15:

Yay

# This is the commit message zfsonlinux#16:

Yay

# This is the commit message zfsonlinux#17:

Yay

# This is the commit message zfsonlinux#18:

Yay

# This is the commit message zfsonlinux#19:

yay

# This is the commit message zfsonlinux#20:

yay

# This is the commit message zfsonlinux#21:

yay

# This is the commit message zfsonlinux#22:

Update ppa script

# This is the commit message zfsonlinux#23:

Update gbp conf with br changes

# This is the commit message zfsonlinux#24:

Update gbp conf with br changes

# This is the commit message zfsonlinux#25:

Bump

# This is the commit message zfsonlinux#26:

No pristine

# This is the commit message zfsonlinux#27:

Bump

# This is the commit message zfsonlinux#28:

Lol whoops

# This is the commit message zfsonlinux#29:

Fix name

# This is the commit message zfsonlinux#30:

Fix name

# This is the commit message zfsonlinux#31:

rebase

# This is the commit message zfsonlinux#32:

Bump

# This is the commit message zfsonlinux#33:

Bump

# This is the commit message zfsonlinux#34:

Bump

# This is the commit message zfsonlinux#35:

Bump

# This is the commit message zfsonlinux#36:

ntrim

# This is the commit message zfsonlinux#37:

Bump

# This is the commit message zfsonlinux#38:

9

# This is the commit message zfsonlinux#39:

Bump

# This is the commit message zfsonlinux#40:

Bump

# This is the commit message zfsonlinux#41:

Bump

# This is the commit message zfsonlinux#42:

Revert "9"

This reverts commit de488f1.

# This is the commit message zfsonlinux#43:

Bump

# This is the commit message zfsonlinux#44:

Account for zconfig.sh being removed

# This is the commit message zfsonlinux#45:

Bump

# This is the commit message zfsonlinux#46:

Add artful

# This is the commit message zfsonlinux#47:

Add in zed.d and zpool.d scripts

# This is the commit message zfsonlinux#48:

Bump

# This is the commit message zfsonlinux#49:

Bump

# This is the commit message zfsonlinux#50:

Bump

# This is the commit message zfsonlinux#51:

Bump

# This is the commit message zfsonlinux#52:

ugh

# This is the commit message zfsonlinux#53:

fix zed upgrade

# This is the commit message zfsonlinux#54:

Bump

# This is the commit message zfsonlinux#55:

conf file zed.d

# This is the commit message #56:

Bump

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment