Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs mount command doesn't respect readonly property #231

Closed
peachpine opened this issue May 6, 2011 · 2 comments
Closed

zfs mount command doesn't respect readonly property #231

peachpine opened this issue May 6, 2011 · 2 comments
Milestone
0.6.0-rc5

Comments

@peachpine
Copy link

Hello, if you have readonly=on set for one of your filesystems, using mount automatically overwrites that setting to readonly=off.

Example:

<~># zfs create auxpool/test

<~># zfs set readonly=on auxpool/test

<~># zfs get readonly auxpool/test
NAME PROPERTY VALUE SOURCE
auxpool/test readonly on local

---- so the readonly flag is set, and now we try to mount it:

<~># zfs mount auxpool/test

<~># zfs get readonly auxpool/test
NAME PROPERTY VALUE SOURCE
auxpool/test readonly off temporary

And now it's been silently overridden. I guess the mount command is secretly specifying "mount -o rw" behind the scenes, but I think it should respect the option set by the filesystem
@behlendorf
Copy link
Contributor

I agree, we should respect the filesystem properties. Thanks for filing this.

@peachpine
Copy link
Author

No, thank YOU. This seams to be a one man show around here and I really appreciate all the effort you've put in to this

kernelOfTruth pushed a commit to kernelOfTruth/zfs that referenced this issue Mar 1, 2015
@dechamps @behlendorf
Fix various generic kmod RPM spec issues.
c1b20ce 
There are a number of issues with the generic kmod RPM spec in its
current state:
 - The "%{__id_u}" macro seems to not be available on some systems (e.g.
   Debian squeeze). It appears it has been deprecated. Use "${__id} -u"
   instead.
 - The way the "--with-linux=" configure option is generated in the
   non-RHEL/Fedora case is completely wrong with various newline and
   escaping issues (also, $kernel_version is not available in the
   generator context).

The second issue made the generator shell snippet (almost) silently
fail, which under specific circumstances can result in broken builds
against the wrong kernel sources.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#231
ahrens pushed a commit to ahrens/zfs that referenced this issue Dec 10, 2020
@pzakha
DLPX-72754 [Backport of DLPX-72753 to 6.0.6.0] initramfs: zfsunlock h…
a345260 
…ook breaks /usr/bin (openzfs#231)

The copy_exec() function expects that the full path of the target
file is passed rather than just the directory, and will take care
of creating the underlying directories if they don't exist.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Closes openzfs#11162
EchterAgo pushed a commit to EchterAgo/zfs that referenced this issue Aug 4, 2023
@andrewc12
Run winbtrfs tests by default (openzfs#231)
467436b 
Signed-off-by: Andrew Innes <andrew.c12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0-rc5
Development

No branches or pull requests
2 participants
@behlendorf @peachpine