We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In taskq_create():
for (t = 0; t < nthreads; t++) VERIFY((tq->tq_threadlist[t] = thread_create(NULL, 0, taskq_thread, tq, TS_RUN, NULL, 0, pri)) != NULL);
Which seemed wrong. In other thread_create() call sites, TS_RUN are the second to the last :
-- module/zfs/arc.c: (void) thread_create(NULL, 0, arc_reclaim_thread, NULL, 0, &p0, module/zfs/arc.c- TS_RUN, defclsyspri); -- module/zfs/arc.c: (void) thread_create(NULL, 0, arc_user_evicts_thread, NULL, 0, &p0, module/zfs/arc.c- TS_RUN, defclsyspri); -- module/zfs/arc.c: (void) thread_create(NULL, 0, l2arc_feed_thread, NULL, 0, &p0, module/zfs/arc.c- TS_RUN, defclsyspri);
The parameters after the thread function should be arg and len.
It's harmless for now because the thread_create() implementation currently ignores some its arguments.
The text was updated successfully, but these errors were encountered:
@thegreatgazoo indeed, good find. If you can open a pull request it looks like an easy fix.
Sorry, something went wrong.
No branches or pull requests
In taskq_create():
Which seemed wrong. In other thread_create() call sites, TS_RUN are the second to the last :
The parameters after the thread function should be arg and len.
It's harmless for now because the thread_create() implementation currently ignores some its arguments.
The text was updated successfully, but these errors were encountered: