Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule a scrub once the resilver is finished #4662

Closed
FransUrbo opened this issue May 18, 2016 · 11 comments

Comments

Projects
None yet
10 participants
@FransUrbo
Copy link
Member

commented May 18, 2016

I'd like the option to schedule a scrub (zpool scrub [pool]) which should run as soon as the current resilver is finished. As it is now, it (the scrub request) will fail and I have to wait at the console until the resilver is done until I can run the scrub.

# zpool scrub share
cannot scrub share: currently resilvering
# zpool status
  pool: share
 state: ONLINE
status: One or more devices is currently being resilvered.  The pool will
        continue to function, possibly in a degraded state.
action: Wait for the resilver to complete.
  scan: resilver in progress since Wed May 18 11:11:32 2016
    130M scanned out of 29.2T at 9.30M/s, (scan is slow, no estimated time)
    5.69M resilvered, 0.00% done

This would probably be something that ZED should deal with.

@ptx0

This comment has been minimized.

Copy link

commented May 18, 2016

resilver already scrubs, no?

@Lilolbet

This comment has been minimized.

Copy link

commented May 18, 2016

No it doesn't. Say you have two mirrors of two drives. You lose one drive in one of the mirrors and replace it. It resilvers from it's mirror companion, not touching the other drives in the pool.

@DeHackEd

This comment has been minimized.

Copy link
Contributor

commented May 18, 2016

A resilver does do a metadata walk of the whole pool, but while a scrub will read from all disks (parity, mirrors and copies/ditto blocks) a resilver will only do so when it involves a disk marked as (resilvering). File data on non-resilvering disks is completely untouched except where needed to rebuild the resilvering disks.

@GregorKopka

This comment has been minimized.

Copy link
Contributor

commented May 23, 2016

Wouldn't be a mode in which the resilver touches everything be better?

@rlaager

This comment has been minimized.

Copy link
Contributor

commented May 23, 2016

Not necessarily. If you have a resilver that is half done, it'd still be better to let it finish before starting the scrub. The behavior requested here would be especially nice for the default system-wide scrubbing script (if your distro has such a thing).

@kingneutron

This comment has been minimized.

Copy link

commented Jun 18, 2016

--Why wait at the console? My philosophy is "Let the machine do the heavy lifting." ;-)

--You can accomplish what you are asking with a shell script (recommend running this as root, in a GNU "screen" session - and don't forget to chmod +x it):

BEGIN partial code for waitresilver-n-scrub.sh

#!/bin/bash

zp=$1 # Pass arg to script

    printf `date +%H:%M:%S`" ...waiting for $zp resilver to complete..."
    waitresilver=1
    while [ $waitresilver -gt 0 ];do 
      waitresilver=`zpool status -v $zp |grep -c resilvering`
      sleep 5
    done 
    echo  `date +%H:%M:%S`' - DONE - Syncing to be sure'; time sync;

do your next thing after this line

zpool scrub $zp

--Man, markup on this site is $bad, handy file attached ;-)
waitresilver.zip

@behlendorf

This comment has been minimized.

Copy link
Member

commented Oct 19, 2016

@tonyhutter this might be a nice configurable way to handle some of drive replacement issues we talked about regarding when a pool should be automatically scrubbed.

@tonyhutter

This comment has been minimized.

Copy link
Member

commented Oct 20, 2016

Yep, this would be very nice. You could kick off a zedlet on a resilver finish event to do it. Below is a completely untested script, using resilver_finish-notify.sh as inspiration. If I wrote it correctly, you should just be able to paste it in cmd/zed/zed.d/resilver_finish-start-scrub.sh and it will work:

# resilver_finish-start-scrub.sh
# Run a scrub after a resilver
#
# Exit codes:
# 9: internal error
#
[ -f "${ZED_ZEDLET_DIR}/zed.rc" ] && . "${ZED_ZEDLET_DIR}/zed.rc"
. "${ZED_ZEDLET_DIR}/zed-functions.sh"

[ -n "${ZEVENT_POOL}" ] || exit 9
[ -n "${ZEVENT_SUBCLASS}" ] || exit 9

zed_check_cmd "${ZPOOL}" || exit 9

if   [ "${ZEVENT_SUBCLASS}" = "resilver_finish" ]; then
    ${ZPOOL} scrub ${ZEVENT_POOL}
fi
@pashford

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2018

If I understand the dRAID information I've been reading, this feature would be very important for pools containing dRAID VDEVs, as a dRAID resilver doesn't do checksum validation of the source data.

Has the above script from @tonyhutter been tested yet?

@behlendorf

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

@pashford yes we're going to want exactly this for dRAID.

@tonyhutter what do you think about opening a PR which adds this script, then create a new test case under tests/zfs-tests/tests/functional/fault/ which verifies it works as intended.

@tonyhutter

This comment has been minimized.

Copy link
Member

commented Jan 12, 2018

@behlendorf good idea, I'm on it.

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 26, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Tweak the resilver_finish event timing so that it happens after the
bad disk has been detached.  Previously you would see the
resilver_finish event and then then the vdev_detach event.

* Add a test mode (-t) option to zed to allow it to use the native
paths to the ZFS utilities.  This is needed when you're running zed
under the ZTS in a local workspace.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 26, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Tweak the resilver_finish event timing so that it happens after the
bad disk has been detached.  Previously you would see the
resilver_finish event and then then the vdev_detach event.

* Add a test mode (-t) option to zed to allow it to use the native
paths to the ZFS utilities.  This is needed when you're running zed
under the ZTS in a local workspace.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

@tonyhutter tonyhutter referenced this issue Jan 26, 2018

Merged

Add scrub after resilver zed script #7086

5 of 13 tasks complete

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 30, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Tweak the resilver_finish event timing so that it happens after the
bad disk has been detached.  Previously you would see the
resilver_finish event and then then the vdev_detach event.

* Add a test mode (-t) option to zed to allow it to use the native
paths to the ZFS utilities.  This is needed when you're running zed
under the ZTS in a local workspace.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 9, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Tweak the resilver_finish event timing so that it happens after the
bad disk has been detached.  Previously you would see the
resilver_finish event and then then the vdev_detach event.

* Add a test mode (-t) option to zed to allow it to use the native
paths to the ZFS utilities.  This is needed when you're running zed
under the ZTS in a local workspace.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 12, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Tweak the resilver_finish event timing so that it happens after the
bad disk has been detached.  Previously you would see the
resilver_finish event and then then the vdev_detach event.

* Add a test mode (-t) option to zed to allow it to use the native
paths to the ZFS utilities.  This is needed when you're running zed
under the ZTS in a local workspace.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 13, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a test mode (-t) option to zed to allow it to use the native
paths to the ZFS utilities.  This is needed when you're running zed
under the ZTS in a local workspace.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 13, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a test mode (-t) option to zed to allow it to use the native
paths to the ZFS utilities.  This is needed when you're running zed
under the ZTS in a local workspace.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 13, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a optional $PATH (-P) option to zed to allow it to use a custom
$PATH for it's zedlets.  This is needed when you're running zed under
the ZTS in a local workspace.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 13, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a optional $PATH (-P) option to zed to allow it to use a custom
$PATH for its zedlets.  This is needed when you're running zed under
the ZTS in a local workspace.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 13, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a optional $PATH (-P) option to zed to allow it to use a custom
$PATH for its zedlets.  This is needed when you're running zed under
the ZTS in a local workspace.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 14, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a optional $PATH (-P) option to zed to allow it to use a custom
$PATH for its zedlets.  This is needed when you're running zed under
the ZTS in a local workspace.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 14, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a optional $PATH (-P) option to zed to allow it to use a custom
$PATH for its zedlets.  This is needed when you're running zed under
the ZTS in a local workspace.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 15, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a optional $PATH (-P) option to zed to allow it to use a custom
$PATH for its zedlets.  This is needed when you're running zed under
the ZTS in a local workspace.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 15, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a optional $PATH (-P) option to zed to allow it to use a custom
$PATH for its zedlets.  This is needed when you're running zed under
the ZTS in a local workspace.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 22, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a optional $PATH (-P) option to zed to allow it to use a custom
$PATH for its zedlets.  This is needed when you're running zed under
the ZTS in a local workspace.

* Update test scripts to not copy in all-debug.sh and all-syslog.sh by
default.  They can be optionally copied in as part of zed_setup().
These scripts slow down zed considerably under heavy events loads and
can cause events to be dropped or their delivery delayed. This was
causing some sporadic failures in the 'fault' tests.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 22, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a optional $PATH (-P) option to zed to allow it to use a custom
$PATH for its zedlets.  This is needed when you're running zed under
the ZTS in a local workspace.

* Update test scripts to not copy in all-debug.sh and all-syslog.sh by
default.  They can be optionally copied in as part of zed_setup().
These scripts slow down zed considerably under heavy events loads and
can cause events to be dropped or their delivery delayed. This was
causing some sporadic failures in the 'fault' tests.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: zfsonlinux#4662

behlendorf added a commit that referenced this issue Feb 23, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a optional $PATH (-P) option to zed to allow it to use a custom
$PATH for its zedlets.  This is needed when you're running zed under
the ZTS in a local workspace.

* Update test scripts to not copy in all-debug.sh and all-syslog.sh by
default.  They can be optionally copied in as part of zed_setup().
These scripts slow down zed considerably under heavy events loads and
can cause events to be dropped or their delivery delayed. This was
causing some sporadic failures in the 'fault' tests.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes #4662 
Closes #7086

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Mar 7, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a optional $PATH (-P) option to zed to allow it to use a custom
$PATH for its zedlets.  This is needed when you're running zed under
the ZTS in a local workspace.

* Update test scripts to not copy in all-debug.sh and all-syslog.sh by
default.  They can be optionally copied in as part of zed_setup().
These scripts slow down zed considerably under heavy events loads and
can cause events to be dropped or their delivery delayed. This was
causing some sporadic failures in the 'fault' tests.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes zfsonlinux#4662
Closes zfsonlinux#7086

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Mar 7, 2018

zfs-0.7.7 squashed patchset
This is a squashed patchset for zfs-0.7.7.  The individual commits are
in the tonyhutter:zfs-0.7.7-hutter branch.  I squashed the commits so
that buildbot wouldn't have to run against each one, and because
github/builbot seem to have a maximum limit of 30 commits they can
test from a PR.

- Linux 4.16 compat: get_disk_and_module() zfsonlinux#7264
- Change checksum & IO delay ratelimit values zfsonlinux#7252
- Increment zil_itx_needcopy_bytes properly zfsonlinux#6988  zfsonlinux#7176
- Fix some typos zfsonlinux#7237
- Fix zpool(8) list example to match actual format zfsonlinux#7244
- Add SMART self-test results to zpool status -c zfsonlinux#7178
- Add scrub after resilver zed script zfsonlinux#4662  zfsonlinux#7086
- Fix free memory calculation on v3.14+ zfsonlinux#7170
- Report duration and error in mmp_history entries zfsonlinux#7190
- Do not initiate MMP writes while pool is suspended zfsonlinux#7182
- Linux 4.16 compat: use correct *_dec_and_test() zfsonlinux#7179  zfsonlinux#7211
- Allow modprobe to fail when called within systemd zfsonlinux#7174
- Add SMART attributes for SSD and NVMe zfsonlinux#7183  zfsonlinux#7193
- Correct count_uberblocks in mmp.kshlib zfsonlinux#7191
- Fix config issues: frame size and headers zfsonlinux#7169
- Clarify zinject(8) explanation of -e zfsonlinux#7172
- OpenZFS 8857 - zio_remove_child() panic due to already destroyed
  parent zio zfsonlinux#7168
- 'zfs receive' fails with "dataset is busy" zfsonlinux#7129  zfsonlinux#7154
- contrib/initramfs: add missing conf.d/zfs zfsonlinux#7158
- mmp should use a fixed tag for spa_config locks zfsonlinux#6530  zfsonlinux#7155
- Handle zap_add() failures in mixed case mode zfsonlinux#7011 zfsonlinux#7054
- Fix zdb -ed on objset for exported pool zfsonlinux#7099 zfsonlinux#6464
- Fix zdb -E segfault zfsonlinux#7099
- Fix zdb -R decompression zfsonlinux#7099  zfsonlinux#4984
- Fix racy assignment of zcb.zcb_haderrors zfsonlinux#7099
- Fix zle_decompress out of bound access zfsonlinux#7099
- Fix zdb -c traverse stop on damaged objset root zfsonlinux#7099
- Linux 4.11 compat: avoid refcount_t name conflict zfsonlinux#7148
- Linux 4.16 compat: inode_set_iversion() zfsonlinux#7148
- OpenZFS 8966 - Source file zfs_acl.c, function zfs_aclset_common
  contains a use after end of the lifetime of a local variable zfsonlinux#7141
- Remove deprecated zfs_arc_p_aggressive_disable zfsonlinux#7135
- Fix default libdir for Debian/Ubuntu zfsonlinux#7083  zfsonlinux#7101
- Bug fix in qat_compress.c for vmalloc addr check zfsonlinux#7125
- Fix systemd_ RPM macros usage on Debian-based distributions zfsonlinux#7074
  zfsonlinux#7100
- Emit an error message before MMP suspends pool zfsonlinux#7048
- ZTS: Fix create-o_ashift test case zfsonlinux#6924  zfsonlinux#6977
- Fix --with-systemd on Debian-based distributions (zfsonlinux#6963) zfsonlinux#6591  zfsonlinux#6963
- Remove vn_rename and vn_remove dependency zfsonlinux/spl#648 zfsonlinux#6753
- Add support for "--enable-code-coverage" option zfsonlinux#6670
- Make "-fno-inline" compile option more accessible zfsonlinux#6605
- Add configure option to enable gcov analysis zfsonlinux#6642
- Implement --enable-debuginfo to force debuginfo zfsonlinux#2734
- Make --enable-debug fail when given bogus args zfsonlinux#2734

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-spl: refs/pull/690/head

@tonyhutter tonyhutter referenced this issue Mar 7, 2018

Closed

zfs-0.7.7 patchset (squashed) #7278

0 of 13 tasks complete

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Mar 12, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a optional $PATH (-P) option to zed to allow it to use a custom
$PATH for its zedlets.  This is needed when you're running zed under
the ZTS in a local workspace.

* Update test scripts to not copy in all-debug.sh and all-syslog.sh by
default.  They can be optionally copied in as part of zed_setup().
These scripts slow down zed considerably under heavy events loads and
can cause events to be dropped or their delivery delayed. This was
causing some sporadic failures in the 'fault' tests.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes zfsonlinux#4662
Closes zfsonlinux#7086

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Mar 13, 2018

zfs-0.7.7 squashed patchset
This is a squashed patchset for zfs-0.7.7.  The individual commits are
in the tonyhutter:zfs-0.7.7-hutter branch.  I squashed the commits so
that buildbot wouldn't have to run against each one, and because
github/builbot seem to have a maximum limit of 30 commits they can
test from a PR.

- Fix MMP write frequency for large pools zfsonlinux#7205 zfsonlinux#7289
- Handle zio_resume and mmp => off zfsonlinux#7286
- Fix zfs-kmod builds when using rpm >= 4.14 zfsonlinux#7284
- zdb and inuse tests don't pass with real disks zfsonlinux#6939 zfsonlinux#7261
- Take user namespaces into account in policy checks zfsonlinux#6800 zfsonlinux#7270
- Detect long config lock acquisition in mmp zfsonlinux#7212
- Linux 4.16 compat: get_disk_and_module() zfsonlinux#7264
- Change checksum & IO delay ratelimit values zfsonlinux#7252
- Increment zil_itx_needcopy_bytes properly zfsonlinux#6988 zfsonlinux#7176
- Fix some typos zfsonlinux#7237
- Fix zpool(8) list example to match actual format zfsonlinux#7244
- Add SMART self-test results to zpool status -c zfsonlinux#7178
- Add scrub after resilver zed script zfsonlinux#4662 zfsonlinux#7086
- Fix free memory calculation on v3.14+ zfsonlinux#7170
- Report duration and error in mmp_history entries zfsonlinux#7190
- Do not initiate MMP writes while pool is suspended zfsonlinux#7182
- Linux 4.16 compat: use correct *_dec_and_test()
- Allow modprobe to fail when called within systemd zfsonlinux#7174
- Add SMART attributes for SSD and NVMe zfsonlinux#7183 zfsonlinux#7193
- Correct count_uberblocks in mmp.kshlib zfsonlinux#7191
- Fix config issues: frame size and headers zfsonlinux#7169
- Clarify zinject(8) explanation of -e zfsonlinux#7172
- OpenZFS 8857 - zio_remove_child() panic due to already destroyed parent zio zfsonlinux#7168
- 'zfs receive' fails with "dataset is busy" zfsonlinux#7129 zfsonlinux#7154
- contrib/initramfs: add missing conf.d/zfs zfsonlinux#7158
- mmp should use a fixed tag for spa_config locks zfsonlinux#6530 zfsonlinux#7155
- Handle zap_add() failures in mixed case mode zfsonlinux#7011 zfsonlinux#7054
- Fix zdb -ed on objset for exported pool zfsonlinux#7099 zfsonlinux#6464
- Fix zdb -E segfault zfsonlinux#7099
- Fix zdb -R decompression zfsonlinux#7099 zfsonlinux#4984
- Fix racy assignment of zcb.zcb_haderrors zfsonlinux#7099
- Fix zle_decompress out of bound access zfsonlinux#7099
- Fix zdb -c traverse stop on damaged objset root zfsonlinux#7099
- Linux 4.11 compat: avoid refcount_t name conflict zfsonlinux#7148
- Linux 4.16 compat: inode_set_iversion() zfsonlinux#7148
- OpenZFS 8966 - Source file zfs_acl.c, function zfs_aclset_common contains a use after end of the lifetime of a local variable zfsonlinux#7141
- Remove deprecated zfs_arc_p_aggressive_disable zfsonlinux#7135
- Fix default libdir for Debian/Ubuntu zfsonlinux#7083 zfsonlinux#7101
- Bug fix in qat_compress.c for vmalloc addr check zfsonlinux#7125
- Fix systemd_ RPM macros usage on Debian-based distributions zfsonlinux#7074 zfsonlinux#7100
- Emit an error message before MMP suspends pool zfsonlinux#7048
- ZTS: Fix create-o_ashift test case zfsonlinux#6924 zfsonlinux#6977
- Fix --with-systemd on Debian-based distributions (zfsonlinux#6963) zfsonlinux#6591 zfsonlinux#6963
- Remove vn_rename and vn_remove dependency zfsonlinux/spl#648 zfsonlinux#6753
- Add support for "--enable-code-coverage" option zfsonlinux#6670
- Make "-fno-inline" compile option more accessible zfsonlinux#6605
- Add configure option to enable gcov analysis zfsonlinux#6642
- Implement --enable-debuginfo to force debuginfo zfsonlinux#2734
- Make --enable-debug fail when given bogus args zfsonlinux#2734

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-spl: refs/pull/690/head

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Mar 13, 2018

zfs-0.7.7 squashed patchset
This is a squashed patchset for zfs-0.7.7.  The individual commits are
in the tonyhutter:zfs-0.7.7-hutter branch.  I squashed the commits so
that buildbot wouldn't have to run against each one, and because
github/builbot seem to have a maximum limit of 30 commits they can
test from a PR.

- Fix MMP write frequency for large pools zfsonlinux#7205 zfsonlinux#7289
- Handle zio_resume and mmp => off zfsonlinux#7286
- Fix zfs-kmod builds when using rpm >= 4.14 zfsonlinux#7284
- zdb and inuse tests don't pass with real disks zfsonlinux#6939 zfsonlinux#7261
- Take user namespaces into account in policy checks zfsonlinux#6800 zfsonlinux#7270
- Detect long config lock acquisition in mmp zfsonlinux#7212
- Linux 4.16 compat: get_disk_and_module() zfsonlinux#7264
- Change checksum & IO delay ratelimit values zfsonlinux#7252
- Increment zil_itx_needcopy_bytes properly zfsonlinux#6988 zfsonlinux#7176
- Fix some typos zfsonlinux#7237
- Fix zpool(8) list example to match actual format zfsonlinux#7244
- Add SMART self-test results to zpool status -c zfsonlinux#7178
- Add scrub after resilver zed script zfsonlinux#4662 zfsonlinux#7086
- Fix free memory calculation on v3.14+ zfsonlinux#7170
- Report duration and error in mmp_history entries zfsonlinux#7190
- Do not initiate MMP writes while pool is suspended zfsonlinux#7182
- Linux 4.16 compat: use correct *_dec_and_test()
- Allow modprobe to fail when called within systemd zfsonlinux#7174
- Add SMART attributes for SSD and NVMe zfsonlinux#7183 zfsonlinux#7193
- Correct count_uberblocks in mmp.kshlib zfsonlinux#7191
- Fix config issues: frame size and headers zfsonlinux#7169
- Clarify zinject(8) explanation of -e zfsonlinux#7172
- OpenZFS 8857 - zio_remove_child() panic due to already destroyed
  parent zio zfsonlinux#7168
- 'zfs receive' fails with "dataset is busy" zfsonlinux#7129 zfsonlinux#7154
- contrib/initramfs: add missing conf.d/zfs zfsonlinux#7158
- mmp should use a fixed tag for spa_config locks zfsonlinux#6530 zfsonlinux#7155
- Handle zap_add() failures in mixed case mode zfsonlinux#7011 zfsonlinux#7054
- Fix zdb -ed on objset for exported pool zfsonlinux#7099 zfsonlinux#6464
- Fix zdb -E segfault zfsonlinux#7099
- Fix zdb -R decompression zfsonlinux#7099 zfsonlinux#4984
- Fix racy assignment of zcb.zcb_haderrors zfsonlinux#7099
- Fix zle_decompress out of bound access zfsonlinux#7099
- Fix zdb -c traverse stop on damaged objset root zfsonlinux#7099
- Linux 4.11 compat: avoid refcount_t name conflict zfsonlinux#7148
- Linux 4.16 compat: inode_set_iversion() zfsonlinux#7148
- OpenZFS 8966 - Source file zfs_acl.c, function zfs_aclset_common
  contains a use after end of the lifetime of a local variable zfsonlinux#7141
- Remove deprecated zfs_arc_p_aggressive_disable zfsonlinux#7135
- Fix default libdir for Debian/Ubuntu zfsonlinux#7083 zfsonlinux#7101
- Bug fix in qat_compress.c for vmalloc addr check zfsonlinux#7125
- Fix systemd_ RPM macros usage on Debian-based distributions zfsonlinux#7074
  zfsonlinux#7100
- Emit an error message before MMP suspends pool zfsonlinux#7048
- ZTS: Fix create-o_ashift test case zfsonlinux#6924 zfsonlinux#6977
- Fix --with-systemd on Debian-based distributions (zfsonlinux#6963) zfsonlinux#6591 zfsonlinux#6963
- Remove vn_rename and vn_remove dependency zfsonlinux/spl#648 zfsonlinux#6753
- Add support for "--enable-code-coverage" option zfsonlinux#6670
- Make "-fno-inline" compile option more accessible zfsonlinux#6605
- Add configure option to enable gcov analysis zfsonlinux#6642
- Implement --enable-debuginfo to force debuginfo zfsonlinux#2734
- Make --enable-debug fail when given bogus args zfsonlinux#2734

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-spl: refs/pull/690/head

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Mar 13, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a optional $PATH (-P) option to zed to allow it to use a custom
$PATH for its zedlets.  This is needed when you're running zed under
the ZTS in a local workspace.

* Update test scripts to not copy in all-debug.sh and all-syslog.sh by
default.  They can be optionally copied in as part of zed_setup().
These scripts slow down zed considerably under heavy events loads and
can cause events to be dropped or their delivery delayed. This was
causing some sporadic failures in the 'fault' tests.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes zfsonlinux#4662
Closes zfsonlinux#7086

tonyhutter added a commit to tonyhutter/zfs that referenced this issue Mar 13, 2018

zfs-0.7.7 squashed patchset
This is a squashed patchset for zfs-0.7.7.  The individual commits are
in the tonyhutter:zfs-0.7.7-hutter branch.  I squashed the commits so
that buildbot wouldn't have to run against each one, and because
github/builbot seem to have a maximum limit of 30 commits they can
test from a PR.

- Fix MMP write frequency for large pools zfsonlinux#7205 zfsonlinux#7289
- Handle zio_resume and mmp => off zfsonlinux#7286
- Fix zfs-kmod builds when using rpm >= 4.14 zfsonlinux#7284
- zdb and inuse tests don't pass with real disks zfsonlinux#6939 zfsonlinux#7261
- Take user namespaces into account in policy checks zfsonlinux#6800 zfsonlinux#7270
- Detect long config lock acquisition in mmp zfsonlinux#7212
- Linux 4.16 compat: get_disk_and_module() zfsonlinux#7264
- Change checksum & IO delay ratelimit values zfsonlinux#7252
- Increment zil_itx_needcopy_bytes properly zfsonlinux#6988 zfsonlinux#7176
- Fix some typos zfsonlinux#7237
- Fix zpool(8) list example to match actual format zfsonlinux#7244
- Add SMART self-test results to zpool status -c zfsonlinux#7178
- Add scrub after resilver zed script zfsonlinux#4662 zfsonlinux#7086
- Fix free memory calculation on v3.14+ zfsonlinux#7170
- Report duration and error in mmp_history entries zfsonlinux#7190
- Do not initiate MMP writes while pool is suspended zfsonlinux#7182
- Linux 4.16 compat: use correct *_dec_and_test()
- Allow modprobe to fail when called within systemd zfsonlinux#7174
- Add SMART attributes for SSD and NVMe zfsonlinux#7183 zfsonlinux#7193
- Correct count_uberblocks in mmp.kshlib zfsonlinux#7191
- Fix config issues: frame size and headers zfsonlinux#7169
- Clarify zinject(8) explanation of -e zfsonlinux#7172
- OpenZFS 8857 - zio_remove_child() panic due to already destroyed
  parent zio zfsonlinux#7168
- 'zfs receive' fails with "dataset is busy" zfsonlinux#7129 zfsonlinux#7154
- contrib/initramfs: add missing conf.d/zfs zfsonlinux#7158
- mmp should use a fixed tag for spa_config locks zfsonlinux#6530 zfsonlinux#7155
- Handle zap_add() failures in mixed case mode zfsonlinux#7011 zfsonlinux#7054
- Fix zdb -ed on objset for exported pool zfsonlinux#7099 zfsonlinux#6464
- Fix zdb -E segfault zfsonlinux#7099
- Fix zdb -R decompression zfsonlinux#7099 zfsonlinux#4984
- Fix racy assignment of zcb.zcb_haderrors zfsonlinux#7099
- Fix zle_decompress out of bound access zfsonlinux#7099
- Fix zdb -c traverse stop on damaged objset root zfsonlinux#7099
- Linux 4.11 compat: avoid refcount_t name conflict zfsonlinux#7148
- Linux 4.16 compat: inode_set_iversion() zfsonlinux#7148
- OpenZFS 8966 - Source file zfs_acl.c, function zfs_aclset_common
  contains a use after end of the lifetime of a local variable zfsonlinux#7141
- Remove deprecated zfs_arc_p_aggressive_disable zfsonlinux#7135
- Fix default libdir for Debian/Ubuntu zfsonlinux#7083 zfsonlinux#7101
- Bug fix in qat_compress.c for vmalloc addr check zfsonlinux#7125
- Fix systemd_ RPM macros usage on Debian-based distributions zfsonlinux#7074
  zfsonlinux#7100
- Emit an error message before MMP suspends pool zfsonlinux#7048
- ZTS: Fix create-o_ashift test case zfsonlinux#6924 zfsonlinux#6977
- Fix --with-systemd on Debian-based distributions (zfsonlinux#6963) zfsonlinux#6591 zfsonlinux#6963
- Remove vn_rename and vn_remove dependency zfsonlinux/spl#648 zfsonlinux#6753
- Fix "--enable-code-coverage" debug build zfsonlinux#6674
- Update codecov.yml zfsonlinux#6669
- Add support for "--enable-code-coverage" option zfsonlinux#6670
- Make "-fno-inline" compile option more accessible zfsonlinux#6605
- Add configure option to enable gcov analysis zfsonlinux#6642
- Implement --enable-debuginfo to force debuginfo zfsonlinux#2734
- Make --enable-debug fail when given bogus args zfsonlinux#2734

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-spl: refs/pull/690/head

tonyhutter added a commit that referenced this issue Mar 19, 2018

Add scrub after resilver zed script
* Add a zed script to kick off a scrub after a resilver.  The script is
disabled by default.

* Add a optional $PATH (-P) option to zed to allow it to use a custom
$PATH for its zedlets.  This is needed when you're running zed under
the ZTS in a local workspace.

* Update test scripts to not copy in all-debug.sh and all-syslog.sh by
default.  They can be optionally copied in as part of zed_setup().
These scripts slow down zed considerably under heavy events loads and
can cause events to be dropped or their delivery delayed. This was
causing some sporadic failures in the 'fault' tests.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes #4662
Closes #7086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.