Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in dsl_dataset.h #6273

Closed
r08ertliu opened this issue Jun 27, 2017 · 1 comment
Closed

Typo in dsl_dataset.h #6273

r08ertliu opened this issue Jun 27, 2017 · 1 comment
Labels
good first issue Indicates a good issue for first-time contributors

Comments

@r08ertliu
Copy link

The parameters dsl_dataset_t *os in function prototype void dsl_dataset_stats(dsl_dataset_t *os, nvlist_t *nv); in dsl_dataset.h seems to be a typo. *os should be changed to *ds?
https://github.com/zfsonlinux/zfs/blob/master/include/sys/dsl_dataset.h#L293

BTW, the definition of dsl_dataset_stats in dsl_dataset.c is using *ds.
https://github.com/zfsonlinux/zfs/blob/master/module/zfs/dsl_dataset.c#L1852
@behlendorf behlendorf added the good first issue Indicates a good issue for first-time contributors label Jun 27, 2017
@behlendorf
Copy link
Contributor

The dsl_dataset_sync, dsl_dataset_sync_done and I'm sure other function prototypes have similar harmless typos. Potentially these could be all be fixed if someone wants to do the cleanup the headers.

@madwizard madwizard mentioned this issue Oct 12, 2017
Merged
11 tasks
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this issue Oct 15, 2017
@madwizard @Nasf-Fan
Typo in dsl_dataset.h
2e9c992 
The parameters dsl_dataset_t *os in function prototype should be
renamed to dsl_dataset_t *ds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Damian Wojsław <damian@wojslaw.pl>
Closes openzfs#6756
Closes openzfs#6273
tonyhutter pushed a commit that referenced this issue Oct 18, 2017
@madwizard @tonyhutter
Typo in dsl_dataset.h
1721f13 
The parameters dsl_dataset_t *os in function prototype should be
renamed to dsl_dataset_t *ds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Damian Wojsław <damian@wojslaw.pl>
Closes #6756
Closes #6273
wli5 pushed a commit to wli5/zfs that referenced this issue Oct 20, 2017
@madwizard @wli5
Typo in dsl_dataset.h
cab03e6 
The parameters dsl_dataset_t *os in function prototype should be
renamed to dsl_dataset_t *ds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Damian Wojsław <damian@wojslaw.pl>
Closes openzfs#6756
Closes openzfs#6273
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this issue Nov 4, 2017
@madwizard @Nasf-Fan
Typo in dsl_dataset.h
12b6119 
The parameters dsl_dataset_t *os in function prototype should be
renamed to dsl_dataset_t *ds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Damian Wojsław <damian@wojslaw.pl>
Closes openzfs#6756
Closes openzfs#6273
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this issue Nov 6, 2017
@madwizard @Nasf-Fan
Typo in dsl_dataset.h
804f7ad 
The parameters dsl_dataset_t *os in function prototype should be
renamed to dsl_dataset_t *ds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Damian Wojsław <damian@wojslaw.pl>
Closes openzfs#6756
Closes openzfs#6273
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this issue Jan 29, 2018
@madwizard @Nasf-Fan
Typo in dsl_dataset.h
473e2f5 
The parameters dsl_dataset_t *os in function prototype should be
renamed to dsl_dataset_t *ds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Damian Wojsław <damian@wojslaw.pl>
Closes openzfs#6756
Closes openzfs#6273
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this issue Feb 13, 2018
@madwizard @Nasf-Fan
Typo in dsl_dataset.h
bce47d0 
The parameters dsl_dataset_t *os in function prototype should be
renamed to dsl_dataset_t *ds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Damian Wojsław <damian@wojslaw.pl>
Closes openzfs#6756
Closes openzfs#6273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Indicates a good issue for first-time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behlendorf @r08ertliu